aaronpuchert wrote:
We don't run into the same issue with the `LLVM` library because
`LLVM_BUILD_LLVM_DYLIB` defaults to off. There is no counterpart toggle for
`clang-cpp`, so it's being built on the bot. I suppose that with
`-DLLVM_BUILD_LLVM_DYLIB=ON` the bot would also run into issues with
aaronpuchert wrote:
> LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running
> on `aix-ppc64` while building `clang,llvm` at step 3 "clean-build-dir".
>
> Full details are available at:
> https://lab.llvm.org/buildbot/#/builders/64/builds/1496
> Here is the relevant piec
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running
on `aix-ppc64` while building `clang,llvm` at step 3 "clean-build-dir".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/64/builds/1496
Here is the relevant piece of the build
aaronpuchert wrote:
@tstellar, seems like we both overlooked the `if("${CMAKE_SYSTEM_NAME}"
STREQUAL "Darwin")`. Any objections to relanding the patch with that additional
condition?
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits ma
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on
`as-worker-93` while building `clang,llvm` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/146/builds/1642
Here is the releva
aaronpuchert wrote:
Went with a version that resembles the following condition and is a bit shorter.
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
tstellar wrote:
@aaronpuchert That looks fine to me.
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
Looks like this broke macOS CI:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/7705/execution/node/45/log/
```
ld: unknown options: --version-script
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
Could you take a look/rev
aaronpuchert wrote:
Same for `if (MSVC)`. So let's make this:
```cmake
if (NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND
NOT MSVC AND NOT LLVM_LINKER_IS_SOLARISLD AND NOT MINGW)
```
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits mai
rastogishubham wrote:
I have reverted the patch with 673b5dd380e8457c887d5b321195d81ea90f134d
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rastogishubham wrote:
Hi this patch has broken the greendragon llvm bot.
Link to failed build:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/15566/
```
ld: unknown options: --version-script
clang: error: linker command failed with exit code 1 (use -v to see invocation)
`
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin`
running on `doug-worker-3` while building `clang,llvm` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/23/builds/4994
Here is the relevant pi
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-4` while building `clang,llvm` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/9808
Here is the relevant
https://github.com/aaronpuchert closed
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar approved this pull request.
This LGTM. I'm fine taking this version instead of my patch.
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
aaronpuchert wrote:
@nikic, thanks for letting me know! That is indeed pretty much the same change.
@tstellar, maybe you want to copy the change to `llvm/CMakeLists.txt`,
otherwise I'd close this.
https://github.com/llvm/llvm-project/pull/116556
___
nikic wrote:
There's an existing PR for this here:
https://github.com/llvm/llvm-project/pull/110758
https://github.com/llvm/llvm-project/pull/116556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Puchert (aaronpuchert)
Changes
The situation that required symbol versions on the LLVM shared library can also
happen for clang-cpp, although it is less common: different tools require
different versions of the library, and through
https://github.com/aaronpuchert created
https://github.com/llvm/llvm-project/pull/116556
The situation that required symbol versions on the LLVM shared library can also
happen for clang-cpp, although it is less common: different tools require
different versions of the library, and through tran
19 matches
Mail list logo
