https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/94208
>From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 3 Jun 2024 13:33:36 +0300
Subject: [PATCH 1/7] Enable LLDB tests in pre-submit CI
---
.ci/generate-bui
https://github.com/AaronBallman commented:
I think it makes a lot of sense for lldb to have a precommit CI pipeline which
tests changes to lldb. I don't think we're at a point where it would make sense
to enable lldb precommit CI testing for changes to clang, though.
For starters, the false po
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/94208
>From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 3 Jun 2024 13:33:36 +0300
Subject: [PATCH 1/6] Enable LLDB tests in pre-submit CI
---
.ci/generate-bui
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/94325 will get us past the compiler
error.
Some things I noticed testing that:
* There is an lld installed on the machine but it's in a path with spaces so
lit can't run it. Generally we'd build lld along with lldb and use that in
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I think the issue is
https://developercommunity.visualstudio.com/t/c-shared-state-futuresstate-default-constructs-the/60897
which appears to have been fixed in 19.32 (https://godbolt.org/z/P594qGrc9).
But @slydiman reports 14.29.30133 which is earlier than that. Perhaps th
DavidSpickett wrote:
> MSVC 14.29.30133 is VS 2019. We are using VS 2022 with the latest Windows SDK
> to build lldb w/o problems.
I also couldn't reproduce it locally with `19.34.31937`, but I may still be
able to reproduce by making my own version of this PR so I can use the CI's
version.
https://github.com/Endilll ready_for_review
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/94208
>From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 3 Jun 2024 13:33:36 +0300
Subject: [PATCH 1/6] Enable LLDB tests in pre-submit CI
---
.ci/generate-bui
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/94208
>From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 3 Jun 2024 13:33:36 +0300
Subject: [PATCH 1/5] Enable LLDB tests in pre-submit CI
---
.ci/generate-bui
Endilll wrote:
> > First Windows CI results: LLDB unit tests do not even build.
>
> Please note the following for Windows setup:
>
> * We used cmake 3.25.3 because we got some issues with the latest cmake.
>
> * python prerequisites are: `python -m pip install swig pexpect psutil`.
>
slydiman wrote:
> First Windows CI results: LLDB unit tests do not even build.
Please note the following for Windows setup:
- We used cmake 3.25.3 because we got some issues with the latest cmake.
- python prerequisites are: `python -m pip install swig pexpect psutil`.
- Most gnu tools may be u
asl wrote:
Tagging @slydiman @vvereschaka
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
CC @omjavaid
https://github.com/llvm/llvm-project/pull/94208#issuecomment-2144949637
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
JDevlieghere wrote:
This is awesome, thank you for working on this!
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/94208
>From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 3 Jun 2024 13:33:36 +0300
Subject: [PATCH 1/4] Enable LLDB tests in pre-submit CI
---
.ci/generate-bui
Endilll wrote:
Linux is passing now in 30 minutes. It's not clear how much overhead LLDB
actually added, because other Linux builds on Clang changes are anywhere
between 22 and 28 minutes.
I'm waiting for https://github.com/llvm/llvm-project/pull/94220 and news
regarding failed MSVC build.
ht
DavidSpickett wrote:
> I'll do that, but I think LLDB should follow the example of MLIR here
https://github.com/llvm/llvm-project/pull/94220
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
DavidSpickett wrote:
> First Windows CI results: LLDB unit tests do not even build.
Linaro's Windows bot uses clang-cl, but I do remember something like this there
too. I will do a local build with msvc and see what I can do.
https://github.com/llvm/llvm-project/pull/94208
Endilll wrote:
@DavidSpickett I made the changes you suggested. Let's see how this Linux run
fares.
Any thoughts on
https://github.com/llvm/llvm-project/pull/94208#issuecomment-2144949637 ?
https://github.com/llvm/llvm-project/pull/94208
___
cfe-comm
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/94208
>From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 3 Jun 2024 13:33:36 +0300
Subject: [PATCH 1/3] Enable LLDB tests in pre-submit CI
---
.ci/generate-bui
Endilll wrote:
> You can either install it with pip
I'll do that, but I think LLDB should follow the example of MLIR here, so that
pipeline scripts don't have hard-coded dependencies for individual projects:
https://github.com/llvm/llvm-project/blob/cee6e81dd2a393ebadac8b620679290851ae446b/.ci/
DavidSpickett wrote:
And I would bet that a majority of the unresolved are due to:
```
ModuleNotFoundError: No module named 'pexpect'
```
You can either install it with `pip` or pass
`-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` to CMake.
https://github.com/llvm/llvm-project/pull/94208
__
DavidSpickett wrote:
> lldb-shell :: SymbolFile/DWARF/x86/module-ownership.mm
This is due to https://github.com/llvm/llvm-project/pull/92083, it's been
reverted now.
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-com
Endilll wrote:
Linux results are ready. `SymbolFile/DWARF/x86/module-ownership.mm` is crashing.
While unresolved tests are not considered failed, if you grep for `FAILED`,
they add a lot of noise that would make harder for people to realize what the
actual reason for CI failure.
All in all, I c
Endilll wrote:
> > @Michael137 This is for Linux. Windows works the same way just below those
> > lines:
> > https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255
>
> Ah, so what would the issue be with just adding
Michael137 wrote:
> @Michael137 This is for Linux. Windows works the same way just below those
> lines:
>
> https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255
Ah, so what would the issue be with just adding more
Endilll wrote:
@Michael137 This is for Linux. Windows works the same way just below those
lines:
https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255
https://github.com/llvm/llvm-project/pull/94208
___
Michael137 wrote:
> > Should we just run the tests for the LLDB C++ language plugin (i.e., the
> > part of LLDB that invokes Clang and the JIT). And then we could expand the
> > set of tests from there later?
>
> In the bash script that currently handles this, "targets that we need to
> check
Endilll wrote:
First Windows CI results: LLDB unit tests do not even build.
```
FAILED:
tools/lldb/unittests/Process/gdb-remote/CMakeFiles/ProcessGdbRemoteTests.dir/GDBRemoteCommunicationClientTest.cpp.obj
sccache C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\cl.exe /nologo
/TP -DB
Endilll wrote:
> Should we just run the tests for the LLDB C++ language plugin (i.e., the part
> of LLDB that invokes Clang and the JIT). And then we could expand the set of
> tests from there later?
In the bash script that currently handles this, "targets that we need to check
if lldb is tes
Michael137 wrote:
Worth a shot i guess. Though it could be somewhat disruptive if we do in fact
have flaky tests. I don't think we need to run *all* tests. Should we just run
the tests for the LLDB C++ language plugin (i.e., the part of LLDB that invokes
Clang and the JIT). And then we could e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vlad Serebrennikov (Endilll)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/94208.diff
2 Files Affected:
- (modified) .ci/generate-buildkite-pipeline-premerge (+1-3)
- (modified) clang/examples/PrintFunctionNames/Prin
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/94208
None
>From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 3 Jun 2024 13:33:36 +0300
Subject: [PATCH 1/2] Enable LLDB tests in pre-submit CI
---
.ci/genera
36 matches
Mail list logo
