https://github.com/arsenm requested changes to this pull request.
Can't really use an attribute for this. Attributes should not be used for
adding constraints to an operation
https://github.com/llvm/llvm-project/pull/121038
___
cfe-commits mailing li
@@ -4120,6 +4120,10 @@ static Value* buildFMulAdd(llvm::Instruction *MulOp,
Value *Addend,
CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd,
Addend->getType()),
{MulOp0, MulOp1, Addend});
+if (negMul)
+
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/121038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4cb2a519db10f54815c8a4ccd5accbedc1cdfd07
9a8925b18e609ac646b2c16da81264a261545513 --e
wzssyqa wrote:
Depends on https://github.com/llvm/llvm-project/pull/121027
https://github.com/llvm/llvm-project/pull/121038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wzssyqa converted_to_draft
https://github.com/llvm/llvm-project/pull/121038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: YunQiang Su (wzssyqa)
Changes
Use negated attribute if negMul or negAdd. So that we can lower
fneg+fmuladd to fmul+fsub if needed.
1) It can save one machine instruction:
fneg/fmul/fadd vs fmul/fsub
2) In strict mode, `c-a*
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: YunQiang Su (wzssyqa)
Changes
Use negated attribute if negMul or negAdd. So that we can lower
fneg+fmuladd to fmul+fsub if needed.
1) It can save one machine instruction:
fneg/fmul/fadd vs fmul/fsub
2) In strict mode, `c-a*b` may b
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: YunQiang Su (wzssyqa)
Changes
Use negated attribute if negMul or negAdd. So that we can lower
fneg+fmuladd to fmul+fsub if needed.
1) It can save one machine instruction:
fneg/fmul/fadd vs fmul/fsub
2) In strict mode, `c-
https://github.com/wzssyqa created
https://github.com/llvm/llvm-project/pull/121038
Use negated attribute if negMul or negAdd. So that we can lower
fneg+fmuladd to fmul+fsub if needed.
1) It can save one machine instruction:
fneg/fmul/fadd vs fmul/fsub
2) In strict mode, `c-a*b` may be
10 matches
Mail list logo
