no92 wrote:
Rebased and updated the PR to include the feedback. We've decided to drop the
`kernel` environment for now, and will maintain it out-of-tree for the time
being. We might come up with a better solution for it in the future, also see
@ArsenArsen's comment above for details why we use
https://github.com/no92 updated https://github.com/llvm/llvm-project/pull/87845
>From 9d681fdec1f5f86244dd0ba429f35805e1ddde61 Mon Sep 17 00:00:00 2001
From: no92
Date: Fri, 6 Sep 2024 21:17:53 +0200
Subject: [PATCH 1/3] [llvm] Add managarm OS target
---
llvm/include/llvm/ADT/bit.h
https://github.com/no92 updated https://github.com/llvm/llvm-project/pull/87845
>From 9d681fdec1f5f86244dd0ba429f35805e1ddde61 Mon Sep 17 00:00:00 2001
From: no92
Date: Fri, 6 Sep 2024 21:17:53 +0200
Subject: [PATCH 1/4] [llvm] Add managarm OS target
---
llvm/include/llvm/ADT/bit.h
avdgrinten wrote:
Regarding the acceptance bar, I'd like to stress the following point: it is
true that Managarm is not a mainstream OS (but neither are some of the other
OSes that have existing LLVM and Clang targets); however, LLVM is an
infrastructure project that is used by a lot of downst
ArsenArsen wrote:
(context: I work(ed) on managarm, but haven't interacted with the LLVM port on
it nearly at all, and have never added targets to LLVM)
The `Kernel` environment probably was added is to mimic what gnuconfig does:
```
~$ /usr/share/gnuconfig/config.sub x86_64-managarm-kernel
x8
mintsuki wrote:
I would remove the `-kernel` environment, only leaving the `-mlibc` environment
which makes sense, similar to `-gnu` and `-musl`.
The rest seems fine to me, but I would change the `defined(__managarm__)` for
`defined(__mlibc__)` wherever possible (adding that macro to mlibc if
MaskRay wrote:
> @MaskRay seems like this target might be too niche to go into LLVM at this
> time? is it worth considering some bar before accepting such a thing into
> LLVM, rather than encouraging folks to maintain such a thing in a branch for
> now?
Good question about the acceptance bar.
dwblaikie wrote:
@MaskRay seems like this target might be too niche to go into LLVM at this
time? is it worth considering some bar before accepting such a thing into LLVM,
rather than encouraging folks to maintain such a thing in a branch for now?
https://github.com/llvm/llvm-project/pull/8784
MaskRay wrote:
#78065 for Hurd is a good example for clang testing.
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> [llvm] Add triples for managarm
I suggest that you split the patch into LLVM target triple part and a clang
part. That's a convention to support new targets.
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing lis
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -279,8 +280,10 @@ class Triple {
Amplification,
OpenCL,
OpenHOS,
+Kernel,
+Mlibc,
MaskRay wrote:
I don't know how Mlibc is intended to be used but LLVM LTO warns about
differing target triples.
https://github.com/llvm/llvm-project/pull
@@ -279,8 +280,10 @@ class Triple {
Amplification,
OpenCL,
OpenHOS,
+Kernel,
MaskRay wrote:
Why is a generic term `Kernel` added? I am concerned that it would cause
confusion to users of other OSes.
Does your OS need a different target triple
MaskRay wrote:
Some older `ToolChain`s were probably contributed with a lot of
`CmdArgs.push_back` uncovered by tests. They are not good examples to follow.
For new `ToolChain`s, we ensure that all constructed `CmdArgs.push_back` are
covered. This allows refactoring by someone who is unfamilia
@@ -2562,7 +2566,10 @@ void
Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes(
static const char *const RISCV64LibDirs[] = {"/lib64", "/lib"};
static const char *const RISCV64Triples[] = {"riscv64-unknown-linux-gnu",
no92 wrote:
Ping
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad0 wrote:
@MaskRay
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
no92 wrote:
Ping
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
no92 wrote:
Ping
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
no92 wrote:
Ping
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/no92 edited https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-adt
Author: no92 (no92)
Changes
This PR aims to add a target for
[managarm](https://github.com/managarm/managarm). The targets
`{x86_64,aarch64,riscv64}-pc-managarm-{kernel,system}` are enabled by this PR
and have been tested to work on managarm.
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: no92 (no92)
Changes
This PR aims to add a target for
[managarm](https://github.com/managarm/managarm). The targets
`{x86_64,aarch64,riscv64}-pc-managarm-{kernel,system}` are enabled by this PR
and have been tested to work on manag
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/no92 created https://github.com/llvm/llvm-project/pull/87845
This PR aims to add a target for
[managarm](https://github.com/managarm/managarm). The targets
`{x86_64,aarch64,riscv64}-pc-managarm-{kernel,system}` are enabled by this PR
and have been tested to work on managarm.
25 matches
Mail list logo
