nikic wrote:
> I wonder if compile-time regressions come from new translation units I add,
> because they definitely include stuff.
Yes, I believe that is the primary contributor. You can see the per-file
breakdown here:
https://llvm-compile-time-tracker.com/compare_clang.php?from=59e2a6b08f3
Endilll wrote:
I wonder if compile-time regressions come from new translation units I add,
because they definitely include stuff.
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
Endilll wrote:
> Mildly curious that there isn't a SemaX86?
>
> Doh, there already is one. Don't mind me.
This PR was based on the success with X86 and RISCV.
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@li
pogo59 wrote:
Mildly curious that there isn't a SemaX86?
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
Thank you for letting me know! Given the amount of positive feedback I've heard
about this effort, I think we'll continue, trying to claw back the compile
times elsewhere (my recent patch that removed try_compile checks from CMake
should've helped, even if it's not counted in yo
nikic wrote:
These Sema refactorings have been increasing the time to build clang by a small
increment with every patch -- this one is an extra large jump of 0.7%
(https://llvm-compile-time-tracker.com/compare.php?from=59e2a6b08f3e40afea87da3838ba69e1e15b6672&to=8aa80199751b0cd6631d057b0bfb2158
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,36 @@
+//===- Attr.h --- Helper functions for attribute handling in Sema
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,36 @@
+//===- Attr.h --- Helper functions for attribute handling in Sema
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,36 @@
+//===- Attr.h --- Helper functions for attribute handling in Sema
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
+ /// AND the ParsedAttr.
+ template
+ static std::enable_if_t, SourceLocation>
+ getAttrLoc(const AttrInfo &AL)
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
+ /// AND the ParsedAttr.
+ template
+ static std::enable_if_t, SourceLocation>
+ getAttrLoc(const AttrInfo &AL)
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
+ /// AND the ParsedAttr.
+ template
+ static std::enable_if_t, SourceLocation>
+ getAttrLoc(const AttrInfo &AL)
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
+ /// AND the ParsedAttr.
+ template
+ static std::enable_if_t, SourceLocation>
+ getAttrLoc(const AttrInfo &AL)
@@ -0,0 +1,94 @@
+//===-- SemaSystemZ.cpp -- SystemZ target-specific routines
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/uweigand edited
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/uweigand commented:
See comment fix - otherwise SystemZ part LGTM.
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SixWeining approved this pull request.
LGTM from the LoongArch side. Thanks!
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
Endilll wrote:
We decided that there's nothing to change here after an offline discussion.
https://
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
erichkeane wrote:
Right, my concern is the comment claims it is for both, but I see you copied it
o
@@ -67,6 +67,7 @@
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/ADT/SmallSet.h"
#include "llvm/ADT/SmallVector.h"
+#include "llvm/ADT/StringExtras.h"
erichkeane wrote:
Got it, thanks!
https://github.com/llvm/llvm-project/pull/93179
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,6 +67,7 @@
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/ADT/SmallSet.h"
#include "llvm/ADT/SmallVector.h"
+#include "llvm/ADT/StringExtras.h"
Endilll wrote:
For `toString(*I, 10, false)` in `CheckUInt32Argument` definition that I moved.
https://git
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
Endilll wrote:
Yes, I moved them together, so
http://eel.is/c++draft/over.match.best#general-2.4 sh
https://github.com/erichkeane commented:
I'm in favor here, the changes to SemaDeclAttr are reasonable.
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -3548,6 +3561,56 @@ class Sema final : public SemaBase {
BuiltinFunction
};
+ /// A helper function to provide Attribute Location for the Attr types
erichkeane wrote:
Is this comment right? ParsedAttr will always call the non-template version
belo
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,6 +67,7 @@
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/ADT/SmallSet.h"
#include "llvm/ADT/SmallVector.h"
+#include "llvm/ADT/StringExtras.h"
erichkeane wrote:
What do we need this addition for?
https://github.com/llvm/llvm-project/pull/93179
_
Endilll wrote:
> Should update the GitHub autolabeler paths for the targets if they don't get
> caught talready
AMDGPU has been already caught, I updated the rest. Thank you!
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing lis
32 matches
Mail list logo
