[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Rahul Joshi via cfe-commits
jurahul wrote: > > > "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly > > > are you trying to achieve and why? Is there an RFC for this given it > > > seems to be having significant consequences across the tree? > > > > > > Yes, please see here: > > https://discourse.l

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: > > "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly are > > you trying to achieve and why? Is there an RFC for this given it seems to > > be having significant consequences across the tree? > > Yes, please see here: > https://discourse.llvm.org/t/rfc-compr

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/112791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly are you trying to achieve and why? Is there an RFC for this given it seems to be having significant consequences across the tree? https://github.com/llvm/llvm-project/pull/112791 __

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Jessica Clarke via cfe-commits
@@ -1,3 +1,4 @@ +// REQUIRES: directx-registered-target jrtc27 wrote: This seems wrong. Emitting LLVM from the Clang frontend should not require anything about the set of targets enabled in LLVM itself. https://github.com/llvm/llvm-project/pull/112791 _

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Rahul Joshi via cfe-commits
jurahul wrote: > "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly are > you trying to achieve and why? Is there an RFC for this given it seems to be > having significant consequences across the tree? Yes, please see here: https://discourse.llvm.org/t/rfc-compress-intrins

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 edited https://github.com/llvm/llvm-project/pull/112791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul converted_to_draft https://github.com/llvm/llvm-project/pull/112791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes --- Patch is 174.94 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/112791.diff 167 Files Affected: - (modified) clang/test/CodeGenHLSL/GlobalConstructorFunctio

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Rahul Joshi (jurahul) Changes --- Patch is 174.94 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/112791.diff 167 Files Affected: - (modified) clang/test/CodeGenHLSL/GlobalConstruc

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/112791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Trim intrinsics (PR #112791)

2024-10-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e26d9070d3eaee587b3ef0da6d12200a5b994765 1edb5e5616f64aa284f205021015efc797800b2a --e