[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

vvereschaka wrote: Reverting the changes is the optimal way in those cases. Yes, would you revert this PR. Thank you. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

justinfargnoli wrote: @vvereschaka, I agree. Note: The problem is that `IRNormalizer` produces a change that invalidates an analysis. It's not that IRNormalizer should declare that it's not preserving an analysis. I likely won't be able to fix this for a few days. @vvereschaka, should I re

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/7518

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

vvereschaka wrote: Looks like these failed tests on [llvm-clang-x86_64-expensive-checks-ubuntu](https://lab.llvm.org/buildbot/#/builders/187) builder are related with this PR: ``` LLVM ERROR: Function @test changed by IRNormalizerPass without invalidating analyses PLEASE submit a bug report to

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

https://github.com/justinfargnoli closed https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

plotfi wrote: LGTM, I would prefer if we landed this and added improvements as needed https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

justinfargnoli wrote: Ping @plotfi @nikic for review. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

justinfargnoli wrote: Ping @plotfi @nikic for review. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

justinfargnoli wrote: Hi @plotfi, thanks for pinging me on this! Generally speaking, two things deserve additional focus: - UX testing to find: - Improvements to existing features - New features to add - Additional testing to ensure that the pass preserves the semantics of the IR. - e.

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

plotfi wrote: @justinfargnoli Is there anything I can do to help with moving this forward, what seems to be the blocker on this at this point (asking to re-attain context)? https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

dtcxzyw wrote: > Any progress? It would be helpful for me to avoid reviewing tons of diff in > https://github.com/dtcxzyw/llvm-opt-benchmark/pulls :) > > Can you resolve merge conflicts first? Emm, as this pass is very time-consuming (even longer than -O3), I plan to create a simpler one for

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

dtcxzyw wrote: > > > I would also try to add this pass at the end of the clang pipeline and > > > run llvm-test-suite to verify that the normalization this does is indeed > > > semantics-preserving. > > > > > > I'm running into some linking errors when trying to build > > [`llvm-test-suite`]

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

dtcxzyw wrote: > Hi @dtcxzyw, thanks for reaching out! > > This MR is blocked because I cannot reproduce the failures @nikic found > [here](https://github.com/llvm/llvm-project/pull/68176#issuecomment-1836365664). > (See [this > comment](https://github.com/llvm/llvm-project/pull/68176#issueco

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

justinfargnoli wrote: Hi @dtcxzyw, thanks for reaching out! This MR is blocked because I cannot reproduce the failures @nikic found [here](https://github.com/llvm/llvm-project/pull/68176#issuecomment-1836365664). (See [this comment](https://github.com/llvm/llvm-project/pull/68176#issuecommen

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

dtcxzyw wrote: Any progress? It would be helpful for me to avoid reviewing tons of diff in https://github.com/dtcxzyw/llvm-opt-benchmark/pulls :) Can you resolve merge conflicts first? https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

justinfargnoli wrote: TODO: Sort function order https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

justinfargnoli wrote: Unless other comments brought up, I'll plan on merging this on Monday the 4th. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang-tools-extra] [clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

@@ -0,0 +1,637 @@ +//===--- IRNormalizer.cpp - IR Normalizer ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.