[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/146813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/6] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/6] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/6] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

AlexVlx wrote: This is the run time part needed to make things work: https://github.com/llvm/llvm-project/pull/146813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/6] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/jmmartinez approved this pull request. It looks good to me, but I'd like for Sam to take an extra look since I'm not familiar with the bigger picture here. https://github.com/llvm/llvm-project/pull/146813 ___ cfe-commits mailing lis

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/146813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/5] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/4] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

@@ -114,24 +115,221 @@ static inline void clearModule(Module &M) { // TODO: simplify. eraseFromModule(*M.ifuncs().begin()); } +static inline SmallVector> +collectIndirectableUses(GlobalVariable *G) { + // We are interested only in use chains that end in an Instruction. +

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/4] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/146813 >From d98e3785a144ada9881cdbe24c86f273850eca20 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 3 Jul 2025 02:02:04 +0100 Subject: [PATCH 1/3] Add support for true globals. --- llvm/lib/Transforms/HipStdPa

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- llvm/lib/Transforms/HipStdPar/HipStdPar.cpp `

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Voicu (AlexVlx) Changes This (mostly) removes one of the largest remaining limitations of `hipstdpar` based algorithm acceleration, by adding support for global variable usage in offloaded algorithms. It is mean to compose with a run

[clang] [llvm] [HIPSTDPAR] Add support for globals (PR #146813)

https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/146813 This (mostly) removes one of the largest remaining limitations of `hipstdpar` based algorithm acceleration, by adding support for global variable usage in offloaded algorithms. It is mean to compose with a run