Endilll wrote:
> Could you merge this for me?
Done.
> On related note, do you think my contributions would count for "a track
> record of submitting high quality patches", i.e. should I apply for commit
> access?
You have unread messages in Discord :)
https://github.com/llvm/llvm-project/pu
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/101548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
Could you merge this for me?
On related note, do you think my contributions would count for "a track record
of submitting high quality patches", i.e. should I apply for commit access?
https://github.com/llvm/llvm-project/pull/101548
_
https://github.com/Endilll approved this pull request.
https://github.com/llvm/llvm-project/pull/101548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/101548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DeinAlptraum wrote:
I can't think of any more genereal approach that prevents this sort of problem.
Type checking would help with this (e.g. giving an error when an unknown
attribute is called on an object) though it wouldn't have worked in this
specific case... otherwise nothing to do but add
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101548
>From e7e66f0f90d7fb9adf3d3f546becd87c7527fa4c Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Thu, 1 Aug 2024 20:01:34 +0100
Subject: [PATCH 1/2] [libclang/python] Fix get_exception_specification_kind
Endilll wrote:
> @Endilll I found another bug on the way, so here's a fix+test. Does this need
> a release note under `Python Binding Changes`?
Yes, the general approach is that every change should come with a test and a
release note.
On a different note, I wonder if there's a way to prevent
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/101548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum updated
https://github.com/llvm/llvm-project/pull/101548
>From e7e66f0f90d7fb9adf3d3f546becd87c7527fa4c Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Thu, 1 Aug 2024 20:01:34 +0100
Subject: [PATCH] [libclang/python] Fix get_exception_specification_kind
---
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
b6b0a240d0b51ce85624a65c6e43f501371bc61b...7e5ff53e8dc56e15f84c3868a25a779be54a22f0
clang
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jannick Kremer (DeinAlptraum)
Changes
This fixes a bug with `get_exception_ specification_kind`. The function did not
work before. Also add a test that confirms that it works now.
---
Full diff: https://github.com/llvm/llvm-project/pull/1
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/101548
This fixes a bug with `get_exception_ specification_kind`. The function did not
work before. Also add a test that confirms that it works now.
>From 7e5ff53e8dc56e15f84c3868a25a779be54a22f0 Mon Sep 17 00:00
13 matches
Mail list logo
