[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s gysit wrote: > To me, it would make sense if mlir-translate didn't care - it doesn't have to > interpret these attributes, does it? It doesn't do anything with them except f

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s AlexisPerry wrote: I have been trying to reproduce my error ever since saying I had one and have been unsuccessful. It now appears that mlir-translate doesn't care about the

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s banach-space wrote: I have X86 disabled - I just double checked. And yes, this test works for me just fine without the guard. Alexis, what error do you get when it fails for

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s AlexisPerry wrote: I ran into failures if I didn't include the guard. I have separate builds for x86 and Aarch64. https://github.com/llvm/llvm-project/pull/96688 __

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s gysit wrote: Interesting! Did you build your LLVM with the x86 target enabled (besides Aarch64)? If not, `mlir-translate` may indeed be fine with the attribute independent o

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s banach-space wrote: Hm, ninja `check-mlir` worked for me just fine on Aarch64 🤔 I think that `mlir-translate` doesn't really care :) Put differently, `REQUIRES` is not neede

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

https://github.com/AlexisPerry updated https://github.com/llvm/llvm-project/pull/96688 >From 2312d31b14aecc6eeea2e81d221ee004e5de3efc Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holby Date: Thu, 6 Jun 2024 14:02:52 -0600 Subject: [PATCH 01/13] [flang] Add basic -mtune support --- clang/includ

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,7 @@ +// RUN: mlir-translate -mlir-to-llvmir %s | FileCheck %s AlexisPerry wrote: Thanks again! Yes, you are absolutely correct. https://github.com/llvm/llvm-project/pull/96688 ___ cfe-commits mailing list

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s AlexisPerry wrote: Thank you so much for the catch! Yes, this guard is absolutely needed. https://github.com/llvm/llvm-project/pull/96688 ___

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,7 @@ +// RUN: mlir-translate -mlir-to-llvmir %s | FileCheck %s gysit wrote: This may require x86-registered-target as well? https://github.com/llvm/llvm-project/pull/96688 ___ cfe-commits mailing list cfe-co

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s gysit wrote: Should this test also be guarded with `REQUIRES: x86-registered-target`? https://github.com/llvm/llvm-project/pull/96688

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

https://github.com/AlexisPerry created https://github.com/llvm/llvm-project/pull/96688 This aims to reland the changes and fix the broken test from PR https://github.com/llvm/llvm-project/pull/95043 >From 2312d31b14aecc6eeea2e81d221ee004e5de3efc Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holb