https://github.com/banach-space approved this pull request.
LGTM, thanks!
> This has only be tested on x86 Linux.
[nit] Note that the test that you've added will run on any platform. Unless
that's referring to something else?
https://github.com/llvm/llvm-project/pull/77360
___
banach-space wrote:
> Caveat: I am new to the driver and toolchain code so please let me know if I
> missed something! 😉
There's very few who aren't :) There's a lot of history for pretty much every
driver flag - I just end up browsing documentation a lot 😂
Here some relevant content online:
ergawy wrote:
Sorry for the late reply. This slipped my mind. Added myself as a reviewer to
not forget.
> Could you take a look at #77135 and see whether `-gpulibc` could be helpful
> for testing?
I don't think this will help since that's a different library, right?
For testing purposes, som
ergawy wrote:
Thanks @tarunprabhu for opening this. I indeed closed my original PR but was
about to reopen it after last week's discussion.
At least for the GNU toolchain, it won't be easy to come up with a simple test
that fails without `-pthread`. The reason is that the pthread API is actual
banach-space wrote:
> @banach-space, Is the intention for the `-pthread` option to be illegal in
> flang?
I'm not aware of such intentions, but if we are to add a flag to Flang, could
we also have a meaningful test?
https://github.com/llvm/llvm-project/pull/75739#issuecomment-1859268789
> At
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Tarun Prabhu (tarunprabhu)
Changes
The -pthread option is supported by both clang and gfortran.
The -pthread option seems to be extensively tested for various platforms by
clang. We should be able to piggy-back on those tests since we use
