https://github.com/kiranchandramohan closed
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidTruby approved this pull request.
LGTM, I'm glad we're matching clang's behaviour here. Thanks!
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/kparzysz approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/luporl approved this pull request.
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -933,10 +933,12 @@ def O : Joined<["-"], "O">, Group,
def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>,
Alias, AliasArgs<["1"]>;
def Ofast : Joined<["-"], "Ofast">, Group,
- Visibility<[ClangOption, CC1Option, FlangOption]>,
- HelpTextForVar
https://github.com/mjklemm approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kkwli approved this pull request.
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu approved this pull request.
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu commented:
Mimicking gfortran's behavior for now seems reasonable to me. We can always
update the warning message later if needed.
Thanks Kiran!
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing l
@@ -933,10 +933,12 @@ def O : Joined<["-"], "O">, Group,
def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>,
Alias, AliasArgs<["1"]>;
def Ofast : Joined<["-"], "Ofast">, Group,
- Visibility<[ClangOption, CC1Option, FlangOption]>,
- HelpTextForVar
@@ -933,10 +933,12 @@ def O : Joined<["-"], "O">, Group,
def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>,
Alias, AliasArgs<["1"]>;
def Ofast : Joined<["-"], "Ofast">, Group,
- Visibility<[ClangOption, CC1Option, FlangOption]>,
- HelpTextForVar
@@ -933,10 +933,12 @@ def O : Joined<["-"], "O">, Group,
def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>,
Alias, AliasArgs<["1"]>;
def Ofast : Joined<["-"], "Ofast">, Group,
- Visibility<[ClangOption, CC1Option, FlangOption]>,
- HelpTextForVar
kiranchandramohan wrote:
I did not see any opposition in
https://discourse.llvm.org/t/rfc-deprecate-ofast-in-flang/80243. So would like
to land this before llvm 20.
https://github.com/llvm/llvm-project/pull/101701
___
cfe-commits mailing list
cfe-com
https://github.com/kiranchandramohan updated
https://github.com/llvm/llvm-project/pull/101701
>From b33ae618fafdad93660eb31368a462e728a2cff9 Mon Sep 17 00:00:00 2001
From: Kiran Chandramohan
Date: Fri, 19 Jul 2024 12:46:08 +
Subject: [PATCH 1/2] [Flang][Driver] Deprecate Ofast
---
clang/i
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Kiran Chandramohan (kiranchandramohan)
Changes
This is subject to agreement by the Flang community
(https://discourse.llvm.org/t/rfc-deprecate-ofast-in-flang/80243).
---
Full diff: https://github.com/llvm
https://github.com/kiranchandramohan created
https://github.com/llvm/llvm-project/pull/101701
This is subject to agreement by the Flang community
(https://discourse.llvm.org/t/rfc-deprecate-ofast-in-flang/80243).
>From 60bd3cf870a078433cfa104bc872ad3083ff1e1c Mon Sep 17 00:00:00 2001
From: Kir
16 matches
Mail list logo
