rorth wrote:
> > The problem is that -u __safestack_init was passed to the linker after the
> > corresponding version of libclang_rt.safestack-*.a. Since the Solaris
> > linker (like Unix linkers for decades) respect
>
> I agree this part should be extracted since it affects other systems. Oth
rorth wrote:
> They look quite independent. Would be possible to split independent fixed
> into a separate patches?
With the exception of the `-u` reordering, they are all Solaris-only, so I kept
them together to avoid tons of micro-patches. I certainly could split them if
you prefer, someth
vitalybuka wrote:
They look quite independent.
Would be possible to split independent fixed into a separate patches?
https://github.com/llvm/llvm-project/pull/98001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
MaskRay wrote:
> At the end of the recent flurry of Illumos (and implicitly Solaris) safestack
> patches, the tests were disabled in
> [b0260c5](https://github.com/llvm/llvm-project/commit/b0260c5b1052f8e3ff1ec77dc42a11f42da762cc)
> without explanation.
@devnexen Thank you for #97183, which s
devnexen wrote:
you do not need to worry I won t do any illumos/solaris work anytime soon, feel
free to do xray port and all the rest.
https://github.com/llvm/llvm-project/pull/98001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
rorth wrote:
> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
> You can test this locally with the following command:
> View the diff from clang-format here.
>
> ```diff
> diff --git a/compiler-rt/lib/safestack/safestack_platform.h
> b/compiler-rt/lib/safestack/safestack_pl
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d6af73e9fbc84315100499a096f17ec5ea23
f8de9c3c2dbde4021f0d32a55c8a385221c0f749 --
rorth wrote:
The mentioned patch to switch safestack to use the `sanitizer_common` functions
instead of their own ones in `sanitizer_platform.h` has to wait until this one
is approved: AFAIT github doesn't support stacked pull requests.
https://github.com/llvm/llvm-project/pull/98001
_
llvmbot wrote:
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Rainer Orth (rorth)
Changes
At the end of the recent flurry of Illumos (and implicitly Solaris) safestack
patches, the tests were disabled in
b0260c5b1052f8e3ff1ec77dc42a11f42da762cc without explanation.
After re-enabling
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/98001
At the end of the recent flurry of Illumos (and implicitly Solaris) safestack
patches, the tests were disabled in
b0260c5b1052f8e3ff1ec77dc42a11f42da762cc without explanation.
After re-enabling them, there were man
10 matches
Mail list logo
