https://github.com/krasimirgg updated
https://github.com/llvm/llvm-project/pull/106242
>From 32e94bde5a8ed401a9fb1255d8394c552da82dd7 Mon Sep 17 00:00:00 2001
From: Krasimir Georgiev
Date: Tue, 27 Aug 2024 16:08:07 +
Subject: [PATCH 1/4] [clang-format] js handle anonymous classes
Addresses
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/106242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
LG except some nits.
https://github.com/llvm/llvm-project/pull/106242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3238,6 +3238,12 @@ TEST_F(TokenAnnotatorTest, BraceKind) {
EXPECT_BRACE_KIND(Tokens[8], BK_BracedInit);
EXPECT_BRACE_KIND(Tokens[11], BK_BracedInit);
EXPECT_BRACE_KIND(Tokens[13], BK_Block);
+
+ Tokens = annotate("a = class extends goog.a {}",
+ge
@@ -579,6 +579,14 @@ TEST_F(FormatTestJS, GoogScopes) {
"});");
}
+TEST_F(FormatTestJS, GoogAnonymousClass) {
krasimirgg wrote:
Thanks! Added one.
https://github.com/llvm/llvm-project/pull/106242
___
https://github.com/krasimirgg updated
https://github.com/llvm/llvm-project/pull/106242
>From 32e94bde5a8ed401a9fb1255d8394c552da82dd7 Mon Sep 17 00:00:00 2001
From: Krasimir Georgiev
Date: Tue, 27 Aug 2024 16:08:07 +
Subject: [PATCH 1/3] [clang-format] js handle anonymous classes
Addresses
@@ -579,6 +579,14 @@ TEST_F(FormatTestJS, GoogScopes) {
"});");
}
+TEST_F(FormatTestJS, GoogAnonymousClass) {
owenca wrote:
Please add a `TokenAnnotatorTest` to test the annotation of the braces instead
of (preferred), or in addition to, this
https://github.com/krasimirgg updated
https://github.com/llvm/llvm-project/pull/106242
>From 32e94bde5a8ed401a9fb1255d8394c552da82dd7 Mon Sep 17 00:00:00 2001
From: Krasimir Georgiev
Date: Tue, 27 Aug 2024 16:08:07 +
Subject: [PATCH 1/2] [clang-format] js handle anonymous classes
Addresses
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 32503050066ed307e6859b3c2ee6fbfa6327ca8b
32e94bde5a8ed401a9fb1255d8394c552da82dd7 --e
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Krasimir Georgiev (krasimirgg)
Changes
Addresses a regression in JavaScript when formatting anonymous classes.
---
Full diff: https://github.com/llvm/llvm-project/pull/106242.diff
2 Files Affected:
- (modified) clang/lib/Format/U
https://github.com/krasimirgg ready_for_review
https://github.com/llvm/llvm-project/pull/106242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/krasimirgg updated
https://github.com/llvm/llvm-project/pull/106242
>From 32e94bde5a8ed401a9fb1255d8394c552da82dd7 Mon Sep 17 00:00:00 2001
From: Krasimir Georgiev
Date: Tue, 27 Aug 2024 16:08:07 +
Subject: [PATCH] [clang-format] js handle anonymous classes
Addresses a r
https://github.com/krasimirgg created
https://github.com/llvm/llvm-project/pull/106242
Addresses a regression in JavaScript when formatting anonymous classes.
>From 32e94bde5a8ed401a9fb1255d8394c552da82dd7 Mon Sep 17 00:00:00 2001
From: Krasimir Georgiev
Date: Tue, 27 Aug 2024 16:08:07 +
S
13 matches
Mail list logo
