[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

https://github.com/gedare closed https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

gedare wrote: The improved fix is in https://github.com/llvm/llvm-project/pull/124891. https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

gedare wrote: I'll rebase on the other PR after it merges. https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

https://github.com/gedare reopened https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

https://github.com/gedare closed https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

gedare wrote: See https://github.com/llvm/llvm-project/pull/124891. https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

@@ -2633,12 +2633,20 @@ class AnnotatingParser { PreviousNotConst->MatchingParen->Previous->isNot(tok::kw_template); } -if ((PreviousNotConst->is(tok::r_paren) && - PreviousNotConst->is(TT_TypeDeclarationParen)) || -PreviousNotConst->is(TT

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

@@ -2633,12 +2633,20 @@ class AnnotatingParser { PreviousNotConst->MatchingParen->Previous->isNot(tok::kw_template); } -if ((PreviousNotConst->is(tok::r_paren) && - PreviousNotConst->is(TT_TypeDeclarationParen)) || -PreviousNotConst->is(TT

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/124634 >From 5292f110ce4c7f5b060165e3c3f817b6716c2c1e Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 27 Jan 2025 14:49:54 -0700 Subject: [PATCH 1/2] [clang-format] Fix annotating attrs in class/struct An attrib

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

gedare wrote: > I'd add an annotating test. (And drop the formatting test.) Yes, that's a good idea, I've done it. I started with the formatting test, but it is unnecessary (although a good, complicated bit of formatting) since the bug was in the annotation. https://github.com/llvm/llvm-proje

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

HazardyKnusperkeks wrote: > (Why drop the formatting test? Seems good to have an integration test for > this, no?) Because the bug was a misannotation. The formatting, based on the annotations, should already be covered. Of course one can always add more tests, and I'm not demanding to remove

[clang] [clang-format] Fix annotating attrs in class/struct (PR #124634)

nico wrote: (Why drop the formatting test? Seems good to have an integration test for this, no?) https://github.com/llvm/llvm-project/pull/124634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c