https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/107506
>From bd7da6ec9afabd829010db4c33d088590ab68b5a Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 5 Sep 2024 19:44:46 -0700
Subject: [PATCH 1/3] [clang-format] Fix a regression on BAS_AlwaysBreak
Fixes #107401.
owenca wrote:
> i've also found 3 more cases that point back to same patch in #107574, in
> case you want to address all of them with this change
I'd rather make incremental changes. Maybe you or @gedare can give them a try.
https://github.com/llvm/llvm-project/pull/107506
@@ -861,7 +861,7 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState
&State, bool DryRun,
// or
// cal(
// new SomethingElseee());
- !IsSimpleFunction(Current)) {
+ Current.isNot(
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/107506
>From bd7da6ec9afabd829010db4c33d088590ab68b5a Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 5 Sep 2024 19:44:46 -0700
Subject: [PATCH 1/2] [clang-format] Fix a regression on BAS_AlwaysBreak
Fixes #107401.
kadircet wrote:
i've also found 3 more cases that point back to same patch in
https://github.com/llvm/llvm-project/issues/107574, in case you want to address
all of them with this change
https://github.com/llvm/llvm-project/pull/107506
___
cfe-commit
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/107506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -861,7 +861,7 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState
&State, bool DryRun,
// or
// cal(
// new SomethingElseee());
- !IsSimpleFunction(Current)) {
+ Current.isNot(
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #107401.
---
Full diff: https://github.com/llvm/llvm-project/pull/107506.diff
2 Files Affected:
- (modified) clang/lib/Format/ContinuationIndenter.cpp (+1-1)
- (modified) clang/unittests/Format/Fo
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/107506
Fixes #107401.
>From bd7da6ec9afabd829010db4c33d088590ab68b5a Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 5 Sep 2024 19:44:46 -0700
Subject: [PATCH] [clang-format] Fix a regression on BAS_AlwaysBreak
Fix
