[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-30 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/146153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-30 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > Thanks! I don't know if similar problems (ODR confused by the > canonicalization merging decltypes with different names of template > parameters) can show up in other cases, but as the PR fixes this particular > case LGTM. Sure, please file bug reports for any other similar

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-30 Thread Maksim Ivanov via cfe-commits
https://github.com/emaxx-google approved this pull request. Thanks! I don't know if similar problems (ODR confused by the canonicalization merging decltypes with different names of template parameters) can show up in other cases, but as the PR fixes this particular case LGTM. https://github.co

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. SGTM https://github.com/llvm/llvm-project/pull/146153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/146153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Matheus Izvekov (mizvekov) Changes This fixes an issue with the ODR checker not using the as-written type of conversion operators. The odr-checker in general should not have to deal with canonical types, as its purpose is to comp

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-27 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/146153 This fixes an issue with the ODR checker not using the as-written type of conversion operators. The odr-checker in general should not have to deal with canonical types, as its purpose is to compare same defin