ficol wrote:
> > > Are fp options (already) handled in constant evaluation?
> >
> >
> > I think they are, there are tests for it in
> > https://github.com/llvm/llvm-project/blob/main/clang/test/AST/const-fpfeatures.c
> > and
> > https://github.com/llvm/llvm-project/blob/main/clang/test/AST/c
tbaederr wrote:
> > Are fp options (already) handled in constant evaluation?
>
> I think they are, there are tests for it in
> https://github.com/llvm/llvm-project/blob/main/clang/test/AST/const-fpfeatures.c
> and
> https://github.com/llvm/llvm-project/blob/main/clang/test/AST/const-fpfeature
tbaederr wrote:
Are fp options (already) handled in constant evaluation?
https://github.com/llvm/llvm-project/pull/125522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ficol edited https://github.com/llvm/llvm-project/pull/125522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -248,4 +248,16 @@ __attribute__((optnone)) T func_22(T x, T y) {
float func_23(float x, float y) {
return func_22(x, y);
-}
\ No newline at end of file
+}
+
+// CHECK-LABEL: FunctionDecl {{.*}} func_24 'vector2float (vector2double)'
+// CHECK: CompoundStmt {{.*}}
https://github.com/ficol updated
https://github.com/llvm/llvm-project/pull/125522
>From cb26d6a13e196bfc08221b7f6cd43ab45019e7d6 Mon Sep 17 00:00:00 2001
From: "Ficek, Jakub"
Date: Mon, 3 Feb 2025 16:45:17 +0100
Subject: [PATCH 1/2] [clang] Handle fp options in __builtin_convertvector
This pat
@@ -5439,3 +5441,21 @@ OpenACCAsteriskSizeExpr *
OpenACCAsteriskSizeExpr::CreateEmpty(const ASTContext &C) {
return new (C) OpenACCAsteriskSizeExpr({}, C.IntTy);
}
+
+ConvertVectorExpr *ConvertVectorExpr::CreateEmpty(const ASTContext &C,
+
https://github.com/erichkeane commented:
1 nit, otherwise no real concerns. I don't know enough about this feature to
be great at reviewing, and the nit might be just a fallout from what we already
have, but otherwise it seems reasonable enough to me.
Glad to see we have a ast-dump test that
https://github.com/shafik commented:
Can we also add a summary, explaining your implementation e.g. "added
TrailingObjects to `ConvertVectorExpr` containing "
https://github.com/llvm/llvm-project/pull/125522
___
cfe-commits mailing list
cfe-commi
@@ -248,4 +248,16 @@ __attribute__((optnone)) T func_22(T x, T y) {
float func_23(float x, float y) {
return func_22(x, y);
-}
\ No newline at end of file
+}
+
+// CHECK-LABEL: FunctionDecl {{.*}} func_24 'vector2float (vector2double)'
+// CHECK: CompoundStmt {{.*}}
@@ -5439,3 +5441,21 @@ OpenACCAsteriskSizeExpr *
OpenACCAsteriskSizeExpr::CreateEmpty(const ASTContext &C) {
return new (C) OpenACCAsteriskSizeExpr({}, C.IntTy);
}
+
+ConvertVectorExpr *ConvertVectorExpr::CreateEmpty(const ASTContext &C,
+
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/125522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
Author: Jakub Ficek (ficol)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/125522.diff
12 Files Affected:
- (modified) clang/include/clang/AST/Expr.h (+76-4)
- (modified) clang/include/clan
https://github.com/ficol ready_for_review
https://github.com/llvm/llvm-project/pull/125522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/ficol created
https://github.com/llvm/llvm-project/pull/125522
None
>From fc40a0fddd830aa1fdfaafa1618acc5c2d0ee5fa Mon Sep 17 00:00:00 2001
From: "Ficek, Jakub"
Date: Mon, 3 Feb 2025 16:45:17 +0100
Subject: [PATCH] [clang] handle fp options in __builtin_convertvector
---
c
16 matches
Mail list logo
