c8ef wrote:
I have opened #109298 for this purpose.
https://github.com/llvm/llvm-project/pull/95917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
FWIW, I think it would be fine to just merge this PR as-is without a test case.
It seems pretty clear that this was the original intention of the code.
https://github.com/llvm/llvm-project/pull/95917
___
cfe-commits mailing list
cfe-commi
kdudka wrote:
@c8ef Cannot we simply replace `continue` with `break` to make it obvious what
the code does?
It would silence the static analysis warning without changing the behavior...
https://github.com/llvm/llvm-project/pull/95917
___
cfe-commits
nikic wrote:
The TryParseProtocolQualifiers code path can be reached using something like
this:
```
struct X {
};
void foo() {
X;
}
```
But I don't know how to make that valid code without it taking some different
code path...
https://github.com/llvm/llvm-project/pull/95917
_
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/95917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall wrote:
> @rjmccall -- do you have ideas on how we can trigger the issue here or do you
> think this code can be removed?
I wouldn't be surprised either way — tentative parsing often contains code that
feels like it ought to be redundant, but it also often takes strange paths in
stran
https://github.com/AaronBallman commented:
Thank you for working on this! I was trying to devise a test case that would
exercise the issue... and I think I've convinced myself this entire function is
dead code. It only seems to be possible to reach in C++ mode, but
`ident` is annotated as a ty
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/95917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (c8ef)
Changes
close: #95895
It appears that there was a logic error in the code of
`Parser::TryParseProtocolQualifiers` related to parsing the identifier list.
This pull request fixed the issue.
---
Full diff: https://github.com/l
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/95917
close: #95895
It appears that there was a logic error in the code of
`Parser::TryParseProtocolQualifiers` related to parsing the identifier list.
This pull request fixed the issue.
>From c3de9995fe46b55360ec13081e
10 matches
Mail list logo
