[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2024-11-26 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I think this makes sense in that case, though I'd wait for @llvm-beanz and @petrhosek too. https://github.com/llvm/llvm-project/pull/71653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2024-11-26 Thread via cfe-commits
whisperity wrote: Took some measurements on X86. Size-wise the CSA-related libraries and objects are roughly the same. We have 2.2G for the three libraries `lib/libclangStaticAnalzyer{Checkers,Core,Frontend}.a` and then another 2.2G for the `tools/clang/lib/StaticAnalyzer/**` object files. The

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2024-11-26 Thread Balazs Benics via cfe-commits
steakhal wrote: As a CSA maintainer, I believe having this component optional is valuable just like @whisperity described. To me, it's not an important subject such that I'd invest time here, but I'm ready to review patches improving the status quo. What is important here that by default it wou

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/71653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-14 Thread Petr Hosek via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) petrhosek wrote: I agree with @llvm-beanz but I'd pr

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-14 Thread Chris B via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) llvm-beanz wrote: > Well yes, but I'm not introducin

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-13 Thread Shoaib Meenai via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) smeenai wrote: I agree with Chris in general. This c

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-13 Thread Timm Baeder via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) tbaederr wrote: Well yes, but I'm not introducing th

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-10 Thread Chris B via cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) llvm-beanz wrote: This approach slightly bothers me.

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes There used to be a patch similar to this on Phabricator. I asked a long time ago if I can pick it up but the author told me they will work on it, which never happened. IIRC there also was a problem with thi

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

2023-11-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71653 There used to be a patch similar to this on Phabricator. I asked a long time ago if I can pick it up but the author told me they will work on it, which never happened. IIRC there also was a problem with this s