[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/124425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Nikita Popov via cfe-commits
@@ -2009,7 +2009,8 @@ class ClassTemplateSpecializationDecl : public CXXRecordDecl, /// Retrieve the template argument list as written in the sources, /// if any. const ASTTemplateArgumentListInfo *getTemplateArgsAsWritten() const { -if (auto *Info = ExplicitInfo.dyn

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/124425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Kazu Hirata via cfe-commits
@@ -885,18 +885,18 @@ class Preprocessor { } ~MacroState() { - if (auto *Info = State.dyn_cast()) + if (auto *Info = dyn_cast_if_present(State)) Info->~ModuleMacroInfo(); } MacroDirective *getLatest() const { - if (auto *Info = State

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Kazu Hirata via cfe-commits
@@ -1391,7 +1391,9 @@ class DeclContextLookupResult { const_iterator end() const { return iterator(); } bool empty() const { return Result.isNull(); } - bool isSingleResult() const { return Result.dyn_cast(); } + bool isSingleResult() const { +return dyn_cast_if_pre

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/124425 >From 8586c0eae876176888bba3f9f9b8f2a83eea9684 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 25 Jan 2025 10:38:03 -0800 Subject: [PATCH 1/2] [clang] Migrate away from PointerUnion::dyn_cast (NFC)

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Nikita Popov via cfe-commits
@@ -885,18 +885,18 @@ class Preprocessor { } ~MacroState() { - if (auto *Info = State.dyn_cast()) + if (auto *Info = dyn_cast_if_present(State)) Info->~ModuleMacroInfo(); } MacroDirective *getLatest() const { - if (auto *Info = State

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Kazu Hirata via cfe-commits
@@ -2009,7 +2009,8 @@ class ClassTemplateSpecializationDecl : public CXXRecordDecl, /// Retrieve the template argument list as written in the sources, /// if any. const ASTTemplateArgumentListInfo *getTemplateArgsAsWritten() const { -if (auto *Info = ExplicitInfo.dyn

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Nikita Popov via cfe-commits
@@ -1391,7 +1391,9 @@ class DeclContextLookupResult { const_iterator end() const { return iterator(); } bool empty() const { return Result.isNull(); } - bool isSingleResult() const { return Result.dyn_cast(); } + bool isSingleResult() const { +return dyn_cast_if_pre

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Nikita Popov via cfe-commits
@@ -2009,7 +2009,8 @@ class ClassTemplateSpecializationDecl : public CXXRecordDecl, /// Retrieve the template argument list as written in the sources, /// if any. const ASTTemplateArgumentListInfo *getTemplateArgsAsWritten() const { -if (auto *Info = ExplicitInfo.dyn

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast This p

[clang] [clang] Migrate away from PointerUnion::dyn_cast (NFC) (PR #124425)

2025-01-25 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/124425 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast This patch migrat