AaronBallman wrote:
> Thank you everyone for the reviews!
Thank you for the improvement!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
soukatch wrote:
Thank you everyone for the reviews!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@soukatch Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/3] [clang] MangledSymbol: remove pointless copy of vector
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
soukatch wrote:
@AaronBallman would it be possible to get an approval while all the checks are
green? Thanks!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/3] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/3] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/Endilll approved this pull request.
Thank you for spotting and fixing this!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Endilll wrote:
@shafik I wonder how checking size of a vector is now considered an expensive
check.
(I stumbled upon it while reviewing)
https://github.com/llvm/llvm-project/blob/47682e4b4a0c8e7637d65868a7208aa6806a50f4/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp#L99-L101
https://gith
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH] [clang] MangledSymbol: remove pointless copy of vector
---
cla
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From b8e20a5a3e37ab9a657ac640b848f638387215fa Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector
---
shafik wrote:
> Looking at the logs, and the error seems to be unrelated to the changes made
> https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446
You can try using `--allow-empty` to do an empty commit to kick off the build
again.
https://git
soukatch wrote:
Looking at the logs, and the error seems to be unrelated to the changes made
https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446
https://github.com/llvm/llvm-project/pull/90012
___
cfe-c
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
soukatch wrote:
@dcb314 @shafik @EugeneZelenko Please let me know if this change looks good.
Thanks!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andrew Sukach (soukatch)
Changes
This pr addresses #87255 adds a std::move call to the names in
MangledSymbol's constructor.
---
Full diff: https://github.com/llvm/llvm-project/pull/90012.diff
1 Files Affected:
- (modified) clang/lib/F
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/soukatch created
https://github.com/llvm/llvm-project/pull/90012
This pr addresses #87255 adds a std::move call to the names in MangledSymbol's
constructor.
>From b8e20a5a3e37ab9a657ac640b848f638387215fa Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22
21 matches
Mail list logo
