ille-apple wrote:
Ping.
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2764,6 +2794,9 @@ void CodeGenFunction::emitByrefStructureInit(const
AutoVarEmission &emission) {
auto layoutInfo = CGM.getObjCRuntime().BuildByrefLayout(CGM, type);
storeHeaderField(layoutInfo, getPointerSize(), "byref.layout");
}
+
+ if (emission.NeedsInitOnHe
@@ -2764,6 +2794,9 @@ void CodeGenFunction::emitByrefStructureInit(const
AutoVarEmission &emission) {
auto layoutInfo = CGM.getObjCRuntime().BuildByrefLayout(CGM, type);
storeHeaderField(layoutInfo, getPointerSize(), "byref.layout");
}
+
+ if (emission.NeedsInitOnHe
https://github.com/ille-apple edited
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ille-apple edited
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2764,6 +2794,9 @@ void CodeGenFunction::emitByrefStructureInit(const
AutoVarEmission &emission) {
auto layoutInfo = CGM.getObjCRuntime().BuildByrefLayout(CGM, type);
storeHeaderField(layoutInfo, getPointerSize(), "byref.layout");
}
+
+ if (emission.NeedsInitOnHe
https://github.com/ille-apple updated
https://github.com/llvm/llvm-project/pull/89475
>From 26be4b6332bf6b58b3d99bb0065b854dcce2a944 Mon Sep 17 00:00:00 2001
From: ille-apple
Date: Fri, 19 Apr 2024 15:36:44 -0700
Subject: [PATCH 1/3] [clang] Fix self-capturing `__block` variables
Clang special
https://github.com/ille-apple updated
https://github.com/llvm/llvm-project/pull/89475
>From 26be4b6332bf6b58b3d99bb0065b854dcce2a944 Mon Sep 17 00:00:00 2001
From: ille-apple
Date: Fri, 19 Apr 2024 15:36:44 -0700
Subject: [PATCH 1/2] [clang] Fix self-capturing `__block` variables
Clang special
@@ -2764,6 +2794,9 @@ void CodeGenFunction::emitByrefStructureInit(const
AutoVarEmission &emission) {
auto layoutInfo = CGM.getObjCRuntime().BuildByrefLayout(CGM, type);
storeHeaderField(layoutInfo, getPointerSize(), "byref.layout");
}
+
+ if (emission.NeedsInitOnHe
@@ -2120,27 +2066,33 @@ void CodeGenFunction::EmitAutoVarCleanups(const
AutoVarEmission &emission) {
// us from jumping into any of these scopes anyway.
if (!HaveInsertPoint()) return;
- const VarDecl &D = *emission.Variable;
+ // If we're initializing directly on the h
@@ -2653,11 +2655,39 @@ const BlockByrefInfo
&CodeGenFunction::getBlockByrefInfo(const VarDecl *D) {
info.FieldOffset = varOffset;
info.ByrefAlignment = std::max(varAlign, getPointerAlign());
+ // If we're initializing directly on the heap, then we should emit a
+ // no
@@ -2653,11 +2655,39 @@ const BlockByrefInfo
&CodeGenFunction::getBlockByrefInfo(const VarDecl *D) {
info.FieldOffset = varOffset;
info.ByrefAlignment = std::max(varAlign, getPointerAlign());
+ // If we're initializing directly on the heap, then we should emit a
+ // no
@@ -2499,21 +2501,21 @@ CodeGenFunction::buildByrefHelpers(llvm::StructType
&byrefType,
// byref routines.
case Qualifiers::OCL_Weak:
return ::buildByrefHelpers(CGM, byrefInfo,
- ARCWeakByrefHelpers(valueAlignment));
+
ille-apple wrote:
Weekly ping.
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 commented:
Serialization related change looks trivial and good. But I feel better to leave
the formal approval to CG part reviewers.
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits
ille-apple wrote:
Rebased due to merge conflict.
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ille-apple updated
https://github.com/llvm/llvm-project/pull/89475
>From 26be4b6332bf6b58b3d99bb0065b854dcce2a944 Mon Sep 17 00:00:00 2001
From: ille-apple
Date: Fri, 19 Apr 2024 15:36:44 -0700
Subject: [PATCH] [clang] Fix self-capturing `__block` variables
Clang special-cas
ille-apple wrote:
Ping :)
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ille-apple updated
https://github.com/llvm/llvm-project/pull/89475
>From 9c61a1d684a15153ea73e2036cdf978ff187c44d Mon Sep 17 00:00:00 2001
From: ille-apple
Date: Fri, 19 Apr 2024 15:36:44 -0700
Subject: [PATCH 1/2] [clang] Fix self-capturing `__block` variables
Clang special
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b6628c24ef017138b8d6eb288e94c141e7c846b0
9c61a1d684a15153ea73e2036cdf978ff187c44d --
ille-apple wrote:
Rebased, because the original version failed CI due to a regression on `main`
(#89476).
https://github.com/llvm/llvm-project/pull/89475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/ille-apple updated
https://github.com/llvm/llvm-project/pull/89475
>From 9c61a1d684a15153ea73e2036cdf978ff187c44d Mon Sep 17 00:00:00 2001
From: ille-apple
Date: Fri, 19 Apr 2024 15:36:44 -0700
Subject: [PATCH] [clang] Fix self-capturing `__block` variables
Clang special-cas
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: None (ille-apple)
Changes
This is an updated version of https://reviews.llvm.org/D90434 from 2020. Due
to time constraints I stopped working on the patch, and unfortunately never got
back around to it until now.
Clang special-ca
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (ille-apple)
Changes
This is an updated version of https://reviews.llvm.org/D90434 from 2020. Due
to time constraints I stopped working on the patch, and unfortunately never got
back around to it until now.
Clang special-cases `__b
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/ille-apple created
https://github.com/llvm/llvm-project/pull/89475
This is an updated version of https://reviews.llvm.org/D90434 from 2020. Due
to time constraints I stopped working on the patch, and unfortunately never got
back around to it until now.
Clang special-cases
26 matches
Mail list logo
