https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/67331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
Thanks for the review @erichkeane!
https://github.com/llvm/llvm-project/pull/67331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal resolved
https://github.com/llvm/llvm-project/pull/67331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal resolved
https://github.com/llvm/llvm-project/pull/67331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/67331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
> Also, it appears that the clang-format bot dislikes this commit (but
> frustratingly won't tell us why?), so perhaps run `git clang-format against
> all the commits here`
Yup, I have it on save already. It complains about lines I never touched.
As per guidelines, I only run c
@@ -320,11 +320,12 @@ namespace {
}
std::string getIsOmitted() const override {
- if (type == "IdentifierInfo *")
+ StringRef T = type;
+ if (T == "IdentifierInfo *" || T == "Expr *")
return "!get" + getUpperName().str() + "()";
- if (type
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/67331
>From 988dcf4f568a58d9b1127b2adf8890a7c7867ac5 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Mon, 25 Sep 2023 15:37:34 +0200
Subject: [PATCH 1/2] [clang] Fix pretty-printing assume_aligned attributes
Insid
erichkeane wrote:
Also, it appears that the clang-format bot dislikes this commit (but
frustratingly won't tell us why?), so perhaps run `git clang-format against all
the commits here`
https://github.com/llvm/llvm-project/pull/67331
___
cfe-commits m
@@ -320,11 +320,12 @@ namespace {
}
std::string getIsOmitted() const override {
- if (type == "IdentifierInfo *")
+ StringRef T = type;
+ if (T == "IdentifierInfo *" || T == "Expr *")
return "!get" + getUpperName().str() + "()";
- if (type
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9f276d4ddd0efa2e323d674a35317c253ab66d58
67e19382fb45fe5e06a5c8de2e7b1434c8b1c68f --
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/67331
>From 988dcf4f568a58d9b1127b2adf8890a7c7867ac5 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Mon, 25 Sep 2023 15:37:34 +0200
Subject: [PATCH] [clang] Fix pretty-printing assume_aligned attributes
Inside `w
@@ -320,10 +320,11 @@ namespace {
}
std::string getIsOmitted() const override {
- if (type == "IdentifierInfo *")
-return "!get" + getUpperName().str() + "()";
- if (type == "TypeSourceInfo *")
+ StringRef T = type;
+ if (T == "TypeSourceInf
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/67331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/67331
>From 67e19382fb45fe5e06a5c8de2e7b1434c8b1c68f Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Mon, 25 Sep 2023 15:37:34 +0200
Subject: [PATCH] [clang] Fix pretty-printing assume_aligned attributes
Inside `w
@@ -320,10 +320,11 @@ namespace {
}
std::string getIsOmitted() const override {
- if (type == "IdentifierInfo *")
-return "!get" + getUpperName().str() + "()";
- if (type == "TypeSourceInfo *")
+ StringRef T = type;
+ if (T == "TypeSourceInf
@@ -320,10 +320,11 @@ namespace {
}
std::string getIsOmitted() const override {
- if (type == "IdentifierInfo *")
-return "!get" + getUpperName().str() + "()";
- if (type == "TypeSourceInfo *")
+ StringRef T = type;
+ if (T == "TypeSourceInf
@@ -320,10 +320,11 @@ namespace {
}
std::string getIsOmitted() const override {
- if (type == "IdentifierInfo *")
-return "!get" + getUpperName().str() + "()";
- if (type == "TypeSourceInfo *")
+ StringRef T = type;
+ if (T == "TypeSourceInf
@@ -320,10 +320,11 @@ namespace {
}
std::string getIsOmitted() const override {
- if (type == "IdentifierInfo *")
-return "!get" + getUpperName().str() + "()";
- if (type == "TypeSourceInfo *")
+ StringRef T = type;
+ if (T == "TypeSourceInf
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Inside `writePrettyPrintFunction()`, we check if we need to emit the given
argument:
```C++
if (!arg->isOptional() || arg->getIsOmitted() == "false") {
FoundNonOptArg = true;
continue;
}
```
For the `AssumeAligned` attribute, the se
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/67331
Inside `writePrettyPrintFunction()`, we check if we need to emit the given
argument:
```C++
if (!arg->isOptional() || arg->getIsOmitted() == "false") {
FoundNonOptArg = true;
continue;
}
```
For the `Ass
21 matches
Mail list logo
