thebrandre wrote:
Thanks for the feedback @cor3ntin! 🙂
I will change the title of the PR and of the commit message to:
> _[clang] Fix implicit integer conversion for opaque enum declarations in
> class templates_
adopting the terminology from [[dcl.enum]](https://wg21.link/dcl.enum) if that
cor3ntin wrote:
Thanks for the PR. Can you update the commit message to be more descriptive?
I'm not sure the fix is sufficient.
I think most of the checks done in `ActOnEnumBody` should be (re) performed on
instantiation.
Maybe we should instead
- Add a new `BuildEnumBody` function, move mos
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (thebrandre)
Changes
This commit fixes implicit integer conversions for _opaque-enum-declarations_
inside a class template with a specified _enum-base_ (see [dcl.enum]).
Previously, the promotion type of the instantiated enum was se
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/thebrandre created
https://github.com/llvm/llvm-project/pull/121039
This commit fixes implicit integer conversions for _opaque-enum-declarations_
inside a class template with a specified _enum-base_ (see [dcl.enum]).
Previously, the promotion type of the instantiated enum w
