[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-18 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Release branch cherry-pick https://github.com/llvm/llvm-project/pull/112855 https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-18 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/112708 >From c40ea631fc1ec226b644b1df2d1dca1c8646c992 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Thu, 17 Oct 2024 06:43:13 -0700 Subject: [PATCH 1/2] [clang] Fix C23 constexpr crashes Before using

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Timm Baeder via cfe-commits
tbaederr wrote: Agreed, LGTM. The first comment in `VarDecl::hasConstantInitialization()` could use some love, since it's no longer true for global constexpr variables. https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mailing list cfe-

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. These changes seem reasonable to me, and likely worth backporting (CC @tbaederr for a second set of eyes just to be sure) https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mail

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Before using a constexpr variable that is not properly initialized check that it is valid. Fixes https://github.com/llvm/llvm-project/issues/109095 Fixes https://github.com/llvm/llvm-project/issu

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/112708 Before using a constexpr variable that is not properly initialized check that it is valid. Fixes https://github.com/llvm/llvm-project/issues/109095 Fixes https://github.com/llvm/llvm-project/issues/112516 >