https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/97619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov approved this pull request.
LGTM as well.
https://github.com/llvm/llvm-project/pull/97619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/premanandrao updated
https://github.com/llvm/llvm-project/pull/97619
>From e1076942f07b1d2de857688c88de6ff966861650 Mon Sep 17 00:00:00 2001
From: Premanand M Rao
Date: Wed, 3 Jul 2024 11:20:42 -0700
Subject: [PATCH 1/4] [clang] Diagnose use of deprecated template alias
Issu
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/97619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,72 @@
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
+//
+// This test checks that a deprecated attribute on an alias
+// template triggers a warning diagnostic when it is used.
+
+template
+struct NoAttr {
+ void foo() {}
+};
+
+// expected-note@+2 5{{'Using
https://github.com/premanandrao updated
https://github.com/llvm/llvm-project/pull/97619
>From e1076942f07b1d2de857688c88de6ff966861650 Mon Sep 17 00:00:00 2001
From: Premanand M Rao
Date: Wed, 3 Jul 2024 11:20:42 -0700
Subject: [PATCH 1/4] [clang] Diagnose use of deprecated template alias
Issu
https://github.com/premanandrao updated
https://github.com/llvm/llvm-project/pull/97619
>From e1076942f07b1d2de857688c88de6ff966861650 Mon Sep 17 00:00:00 2001
From: Premanand M Rao
Date: Wed, 3 Jul 2024 11:20:42 -0700
Subject: [PATCH 1/3] [clang] Diagnose use of deprecated template alias
Issu
@@ -0,0 +1,72 @@
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
+//
+// This test checks that a deprecated attribute on an alias
+// template triggers a warning diagnostic when it is used.
+
+template
+struct NoAttr {
+ void foo() {}
+};
+
+// expected-note@+2 5{{'Using
https://github.com/AaronBallman commented:
Thank you for this, the changes should also come with a release note in
clang/docs/ReleaseNotes.rst so users know about the improvement. Changes
generally LG, but I did have some test suggestions.
https://github.com/llvm/llvm-project/pull/97619
__
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/97619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,58 @@
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
+//
+// This test checks that a deprecated attribute on an alias
+// template triggers a warning diagnostic when it is used.
+
+template
+struct NoAttr {
+ void foo() {}
+};
+
+// expected-note@+2 5{{'Using
https://github.com/premanandrao updated
https://github.com/llvm/llvm-project/pull/97619
>From e1076942f07b1d2de857688c88de6ff966861650 Mon Sep 17 00:00:00 2001
From: Premanand M Rao
Date: Wed, 3 Jul 2024 11:20:42 -0700
Subject: [PATCH 1/2] [clang] Diagnose use of deprecated template alias
Issu
@@ -0,0 +1,58 @@
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
+//
+// This test checks that a deprecated attribute on an alias
+// template triggers a warning diagnostic when it is used.
+
+template
+struct NoAttr {
+ void foo() {}
+};
+
+// expected-note@+2 5{{'Using
ldionne wrote:
@premanandrao There are instructions here:
https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build
You can also use e.g. `run-buildbot` for this job:
https://github.com/llvm/llvm-project/blob/c7961538ff5c73ad03cbf2470e56cdc10cedc83b/libcxx/utils/ci/run-buildbot#L366
You
premanandrao wrote:
> I just ran the bootstrapping build with this patch applied and ran
> `check-runtimes`, and nothing failed. This might not be sufficient (perhaps I
> missed something important), but at first glance it doesn't seem to break
> anything on our side.
Thank you SO much!
Wo
ldionne wrote:
I just ran the bootstrapping build with this patch applied and ran
`check-runtimes`, and nothing failed. This might not be sufficient (perhaps I
missed something important), but at first glance it doesn't seem to break
anything on our side.
https://github.com/llvm/llvm-project/
cor3ntin wrote:
@ldionne
https://github.com/llvm/llvm-project/pull/97619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
premanandrao wrote:
> For reference, see https://reviews.llvm.org/D136533 for similar expansion of
> diagnostics for uses of declarations, and how that lead to trouble in MacOS
> land.
> I'd suggest building libc++ on MacOS, to be sure this won't cause regressions
> and a future revert.
Thank
mizvekov wrote:
For reference, see https://reviews.llvm.org/D136533 for similar expansion of
diagnostics for uses of declarations, and how that lead to trouble in MacOS
land.
I'd suggest building libc++ on MacOS, to be sure this won't cause regressions
and a future revert.
I have a MacOS mac
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (premanandrao)
Changes
Issue a warning diagnostic when a template alias with a deprecated attribute is
used.
---
Full diff: https://github.com/llvm/llvm-project/pull/97619.diff
3 Files Affected:
- (modified) clang/lib/Sema/SemaAva
https://github.com/premanandrao created
https://github.com/llvm/llvm-project/pull/97619
Issue a warning diagnostic when a template alias with a deprecated attribute is
used.
>From e1076942f07b1d2de857688c88de6ff966861650 Mon Sep 17 00:00:00 2001
From: Premanand M Rao
Date: Wed, 3 Jul 2024 11:
21 matches
Mail list logo
