https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/106241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/106241
From c8c29eae625991ee1ea7dfbfcda4a31f0b19b2e3 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Tue, 27 Aug 2024 17:56:47 +0200
Subject: [PATCH] [clang] Cleanup IncludeLocMap
CompilerInstance can re-use sam
@@ -453,6 +454,61 @@ TEST_F(SourceManagerTest,
loadedSLocEntryIsInTheSameTranslationUnit) {
#if defined(LLVM_ON_UNIX)
+TEST_F(SourceManagerTest, ResetsIncludeLocMap) {
ilya-biryukov wrote:
Suggestion: add a comment explaining what this aims to test at a mor
https://github.com/ilya-biryukov approved this pull request.
LGMT with a small suggestion.
Thanks for getting the test in!
https://github.com/llvm/llvm-project/pull/106241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/106241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fdca2c33a1f33f4886d969ea0f0219764c7b6b59
f8fb04379255a783f1fbdcd07cfff5846d253d32 --e
@@ -350,6 +350,7 @@ void SourceManager::clearIDTables() {
LastLineNoContentCache = nullptr;
LastFileIDLookup = FileID();
+ IncludedLocMap.clear();
kadircet wrote:
done
https://github.com/llvm/llvm-project/pull/106241
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/106241
From f8fb04379255a783f1fbdcd07cfff5846d253d32 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Tue, 27 Aug 2024 17:56:47 +0200
Subject: [PATCH] [clang] Cleanup IncludeLocMap
CompilerInstance can re-use sam
@@ -350,6 +350,7 @@ void SourceManager::clearIDTables() {
LastLineNoContentCache = nullptr;
LastFileIDLookup = FileID();
+ IncludedLocMap.clear();
ilya-biryukov wrote:
Is there a way to write a unit test checking this behavior?
SourceManager should be r
https://github.com/ilya-biryukov requested changes to this pull request.
This looks good, but I wanted to explore if we could write a unit test for
this...
https://github.com/llvm/llvm-project/pull/106241
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/106241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: kadir çetinkaya (kadircet)
Changes
CompilerInstance can re-use same SourceManager across multiple
frontendactions. During this process it calls
`SourceManager::clearIDTables` to reset any caches based on FileIDs.
It didn't reset IncludeLoc
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/106241
CompilerInstance can re-use same SourceManager across multiple
frontendactions. During this process it calls
`SourceManager::clearIDTables` to reset any caches based on FileIDs.
It didn't reset IncludeLocMap, r
13 matches
Mail list logo
