[clang] [clang] Check specialization for annotation (PR #117315)

@@ -1763,6 +1763,8 @@ class Sema final : public SemaBase { /// Add [[gsl::Pointer]] attributes for std:: types. void inferGslPointerAttribute(TypedefNameDecl *TD); + static bool isPointerLikeType(QualType QT); usx95 wrote: Added comments. Also moved to C

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/8] [clang] Check specialization for annotation --- clang/lib/S

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/7] [clang] Check specialization for annotation --- clang/lib/S

[clang] [clang] Check specialization for annotation (PR #117315)

hokein wrote: The PR description needs to update as well. https://github.com/llvm/llvm-project/pull/117315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Check specialization for annotation (PR #117315)

@@ -1763,6 +1763,8 @@ class Sema final : public SemaBase { /// Add [[gsl::Pointer]] attributes for std:: types. void inferGslPointerAttribute(TypedefNameDecl *TD); + static bool isPointerLikeType(QualType QT); hokein wrote: nit: please add some comments

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/117315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/6] [clang] Check specialization for annotation --- clang/lib/S

[clang] [clang] Check specialization for annotation (PR #117315)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 89b08c8ee7b5184f8cfb0d356f2762173fb87d42 a847f8bf8d02edb0b9615856713ec122cee1e927 --e

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/5] [clang] Check specialization for annotation --- clang/lib/S

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/4] [clang] Check specialization for annotation --- clang/lib/S

[clang] [clang] Check specialization for annotation (PR #117315)

@@ -1763,6 +1763,18 @@ class Sema final : public SemaBase { /// Add [[gsl::Pointer]] attributes for std:: types. void inferGslPointerAttribute(TypedefNameDecl *TD); + template static bool isRecordWithAttr(QualType Type) { hokein wrote: I'd avoid expose

[clang] [clang] Check specialization for annotation (PR #117315)

@@ -253,9 +253,12 @@ static void visitLocalsRetainedByReferenceBinding(IndirectLocalPath &Path, LocalVisitor Visit); template static bool isRecordWithAttr(QualType Type) { - if (auto *RD = Type->getAsCXXRecordDecl()) -re

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/3] [clang] Check specialization for annotation --- clang/lib/S

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/117315 >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH 1/2] [clang] Check specialization for annotation --- clang/lib/S

[clang] [clang] Check specialization for annotation (PR #117315)

@@ -253,9 +253,12 @@ static void visitLocalsRetainedByReferenceBinding(IndirectLocalPath &Path, LocalVisitor Visit); template static bool isRecordWithAttr(QualType Type) { - if (auto *RD = Type->getAsCXXRecordDecl()) -re

[clang] [clang] Check specialization for annotation (PR #117315)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/117315.diff 1 Files Affected: - (modified) clang/lib/Sema/CheckExprLifetime.cpp (+6-3) ``diff diff --git a/clang/lib/Sema/CheckExprLifet

[clang] [clang] Check specialization for annotation (PR #117315)

https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/117315 None >From e30ae8a6e0c1df8e33c2add6502342cb269c1cfd Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 22 Nov 2024 11:02:49 + Subject: [PATCH] [clang] Check specialization for annotation --- clang/lib