AaronBallman wrote:
> This brings me to conclusion that hand-written style of codegen tests
> presented above is a better fit for purposes of C++ defect report codegen
> tests.
I share that conclusion. I think the hand-written IR is easier for people to
reason because it strips out unrelated
Endilll wrote:
Following the suggestion from @nikic, I prepared two variants of the same test,
one hard-written, and one using `update_cc_test_checks.py` (with heavy manual
editing afterwards). Hand-written:
```
// CHECK-LABEL: define dso_local void @dr1807::f()
// CHECK: invo
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/77637
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan 2024 20:27:53 +0300
Subject: [PATCH 1/7] [clang] Add test for CWG1807
The test checks that objec
@@ -0,0 +1,28 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexc
https://github.com/erichkeane approved this pull request.
1 nit for readability sake, else is good enough.
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -0,0 +1,28 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexc
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/77637
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan 2024 20:27:53 +0300
Subject: [PATCH 1/6] [clang] Add test for CWG1807
The test checks that objec
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/77637
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan 2024 20:27:53 +0300
Subject: [PATCH 1/5] [clang] Add test for CWG1807
The test checks that objec
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/77637
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan 2024 20:27:53 +0300
Subject: [PATCH 1/4] [clang] Add test for CWG1807
The test checks that objec
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
@@ -164,6 +164,8 @@ void A::C::f4() {
}
} // namespace dr1804
+// dr1807 is in separate file
Endilll wrote:
Addressed in the last update.
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
@@ -164,6 +164,8 @@ void A::C::f4() {
}
} // namespace dr1804
+// dr1807 is in separate file
cor3ntin wrote:
Missing a file?
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
cfe-commits@
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/77637
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan 2024 20:27:53 +0300
Subject: [PATCH 1/3] [clang] Add test for CWG1807
The test checks that objec
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/77637
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan 2024 20:27:53 +0300
Subject: [PATCH 1/2] [clang] Add test for CWG1807
The test checks that objec
erichkeane wrote:
> @erichkeane Defect report reads
>
> > The destruction of fully-constructed array elements when array
> > initialization is terminated by an exception is required by 14.3
> > [[except.ctor](https://wg21.link/except.ctor#2)] paragraph 2, but the order
> > in which they are t
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
Endilll wrote:
@erichkeane Defect report reads
> The test should also validate the non-catch case! The destruction order is
> also relevant for the 'try' block's cleanup as well. So there is probably two
> different 'check' sections here that need to happen.
So I think while both your points a
Endilll wrote:
Our C++ DR test suite has little codegen tests (around 3 or 4, depending on how
you count). This rather simple DR about order of destruction of stack unwinding
aims to establish a precedent for how such test should be written. Specific
points I'd like to highlight:
1. Use of `ll
https://github.com/erichkeane commented:
The test should also validate the non-catch case! The destruction order is
also relevant for the 'try' block's cleanup as well. So there is probably two
different 'check' sections here that need to happen.
https://github.com/llvm/llvm-project/pull/776
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o -
-fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s
--check-prefixes CHECK,CXX98
+// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -
-f
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
The test checks that objects in arrays are destructed in reverse order during
stack unwinding.
---
Full diff: https://github.com/llvm/llvm-project/pull/77637.diff
2 Files Affected:
- (added) clang/t
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/77637
The test checks that objects in arrays are destructed in reverse order during
stack unwinding.
>From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 10 Jan
30 matches
Mail list logo
