https://github.com/AaronBallman approved this pull request.
LGTM! What do you think @erichkeane?
https://github.com/llvm/llvm-project/pull/134089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
erichkeane wrote:
Yeah, LGTM. Thank you!
https://github.com/llvm/llvm-project/pull/134089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Ugh, the issue was on my end. I downloaded the changes, rebuilt the
documentation... and skipped the step where I rebuild clang-tblgen. When I do
things properly, it works (shocking, I know).
https://github.com/llvm/llvm-project/pull/134089
_
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/134089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
This is what I'm getting (I applied the patch locally, re-ran clang-tblgen,
then re-ran `make html` to make the docs):
https://github.com/llvm/llvm-project/pull
YLChenZ wrote:
Why is that? It's strange, the first patch I just merged the same Heading, and
then according to your suggestion, the second patch merged the same Content
entries. Then the third patch: did not include Undocumented. I used the build
steps you gave to get this:
https:
AaronBallman wrote:
I thought we decided to merge everything but the undocumented attributes? I'm
still seeing `cf_returns_retained` that's distinct from
`cf_returns_not_retained`, etc.
https://github.com/llvm/llvm-project/pull/134089
___
cfe-commits
https://github.com/YLChenZ edited
https://github.com/llvm/llvm-project/pull/134089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
