[clang] [clang][deps] Stop relying on name of inferred module maps (PR #114085)

2024-11-01 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/114085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Stop relying on name of inferred module maps (PR #114085)

2024-11-01 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: Okay, sounds impractical https://github.com/llvm/llvm-project/pull/114085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Stop relying on name of inferred module maps (PR #114085)

2024-11-01 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Can this be tested? Hmm, I'm not sure. The current tests for inferred module maps still pass. The other ways how `SourceManager` ends up overwriting a file are: * is by using the `-remap-file`, which is unsupported with modules (`ASTWriter` intentionally asserts), * using

[clang] [clang][deps] Stop relying on name of inferred module maps (PR #114085)

2024-10-29 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir commented: Can this be tested? https://github.com/llvm/llvm-project/pull/114085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Stop relying on name of inferred module maps (PR #114085)

2024-10-29 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/114085 What the special case for `"__inferred_module.map"` was getting at is that in general we cannot report overridden files as dependencies: neither the build system nor Clang itself won't know what to do with

[clang] [clang][deps] Stop relying on name of inferred module maps (PR #114085)

2024-10-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes What the special case for `"__inferred_module.map"` was getting at is that in general we cannot report overridden files as dependencies: neither the build system nor Clang itself won't know what to do wi