[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-16 Thread Tim Gymnich via cfe-commits
@@ -155,3 +197,24 @@ int3 test_sign_int64_t3(int64_t3 p0) { return sign(p0); } // CHECK: %hlsl.sign = call <4 x i32> @llvm.[[TARGET]].sign.v4i64( // CHECK: ret <4 x i32> %hlsl.sign int4 test_sign_int64_t4(int64_t4 p0) { return sign(p0); } + + +// CHECK: define [[FNATTRS]] i32 @

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-16 Thread Joshua Batista via cfe-commits
@@ -155,3 +197,24 @@ int3 test_sign_int64_t3(int64_t3 p0) { return sign(p0); } // CHECK: %hlsl.sign = call <4 x i32> @llvm.[[TARGET]].sign.v4i64( // CHECK: ret <4 x i32> %hlsl.sign int4 test_sign_int64_t4(int64_t4 p0) { return sign(p0); } + + +// CHECK: define [[FNATTRS]] i32 @

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-10 Thread Farzon Lotfi via cfe-commits
farzonl wrote: Build failure was on `Driver/hip-partial-link.hip` Not related to this change. Will proceed with merging. https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-09 Thread Tim Gymnich via cfe-commits
tgymnich wrote: Will do that. I just rebased the PR, so feel free to merge this for me in the meanwhile. https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-09 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich updated https://github.com/llvm/llvm-project/pull/108396 >From 74c195399a0ea08de31c7fd546917432aeca5337 Mon Sep 17 00:00:00 2001 From: Tim Gymnich Date: Thu, 12 Sep 2024 15:57:20 +0200 Subject: [PATCH] [clang][HLSL] Add sign intrinsic part 4 - add handling for unsig

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-09 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @tgymnich I think its time for you to ask for commit access. Follow these steps: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commit

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-10-09 Thread Sarah Spall via cfe-commits
https://github.com/spall approved this pull request. https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich created https://github.com/llvm/llvm-project/pull/108396 - add handling for unsigned integers to hlsl_elementwise_sign ### Related PRs - https://github.com/llvm/llvm-project/pull/101987 - https://github.com/llvm/llvm-project/pull/101988 - https://github.com/llvm/llvm

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Tim Gymnich (tgymnich) Changes - Add handling for unsigned integers to hlsl_elementwise_sign - Use `select` instead of adding dx and spirv intrinsics for unsigned integers as [di

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich ready_for_review https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits