https://github.com/chenzheng1030 closed
https://github.com/llvm/llvm-project/pull/106012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexrp wrote:
Forgot to note in the PR description that I don't have commit access.
https://github.com/llvm/llvm-project/pull/106012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chenzheng1030 approved this pull request.
LGTM now. Thanks very much for the fix.
https://github.com/llvm/llvm-project/pull/106012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -402,9 +402,16 @@ void PPCTargetInfo::getTargetDefines(const LangOptions
&Opts,
Builder.defineMacro("__VEC__", "10206");
Builder.defineMacro("__ALTIVEC__");
}
- if (HasSPE) {
+ if (HasSPE)
Builder.defineMacro("__SPE__");
+ if (HasSPE || FloatABI == SoftFlo
https://github.com/alexrp updated
https://github.com/llvm/llvm-project/pull/106012
From 4f766ab372d064ceb0adf2eebdc1c64a9e91c825 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?=
Date: Sun, 25 Aug 2024 22:47:37 +0200
Subject: [PATCH] [clang][Driver] Define soft float macro
@@ -402,9 +402,16 @@ void PPCTargetInfo::getTargetDefines(const LangOptions
&Opts,
Builder.defineMacro("__VEC__", "10206");
Builder.defineMacro("__ALTIVEC__");
}
- if (HasSPE) {
+ if (HasSPE)
Builder.defineMacro("__SPE__");
+ if (HasSPE || FloatABI == SoftFlo
https://github.com/alexrp updated
https://github.com/llvm/llvm-project/pull/106012
From acd4bd9406969926ed7b87c764f02ad072847aff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?=
Date: Sun, 25 Aug 2024 22:47:37 +0200
Subject: [PATCH] [clang][Driver] Define soft float macro
https://github.com/alexrp updated
https://github.com/llvm/llvm-project/pull/106012
From b9e81030a102f52b7d0b4e8a924a112a536601c3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?=
Date: Sun, 25 Aug 2024 22:47:37 +0200
Subject: [PATCH] [clang][Driver] Define soft float macro
@@ -439,14 +443,12 @@ void PPCTargetInfo::getTargetDefines(const LangOptions
&Opts,
// FIXME: The following are not yet generated here by Clang, but are
//generated by GCC:
//
- // _SOFT_FLOAT_
// __RECIP_PRECISION__
// __APPLE_ALTIVEC__
// __RE
@@ -439,14 +443,12 @@ void PPCTargetInfo::getTargetDefines(const LangOptions
&Opts,
// FIXME: The following are not yet generated here by Clang, but are
//generated by GCC:
//
- // _SOFT_FLOAT_
// __RECIP_PRECISION__
// __APPLE_ALTIVEC__
// __RE
@@ -439,14 +443,12 @@ void PPCTargetInfo::getTargetDefines(const LangOptions
&Opts,
// FIXME: The following are not yet generated here by Clang, but are
//generated by GCC:
//
- // _SOFT_FLOAT_
// __RECIP_PRECISION__
// __APPLE_ALTIVEC__
// __RE
https://github.com/ecnelises approved this pull request.
Thanks
https://github.com/llvm/llvm-project/pull/106012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexrp wrote:
@ecnelises done, thank you!
https://github.com/llvm/llvm-project/pull/106012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexrp updated
https://github.com/llvm/llvm-project/pull/106012
From 885a1830bf62e4b928fba65b78d5df9e416cb1a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?=
Date: Sun, 25 Aug 2024 22:47:37 +0200
Subject: [PATCH] [clang][Driver] Define soft float macro
ecnelises wrote:
Could you pick the test change from
https://github.com/ecnelises/llvm-project/commit/9dcb9c96d565f282ca716693b37c65674c3f7edd
into this patch?
https://github.com/llvm/llvm-project/pull/106012
___
cfe-commits mailing list
cfe-commits@
alexrp wrote:
FWIW, if this patch is good, it would be nice to get it into 19.x.
https://github.com/llvm/llvm-project/pull/106012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-powerpc
@llvm/pr-subscribers-clang
Author: Alex Rønne Petersen (alexrp)
Changes
Fixes #105972.
---
Full diff: https://github.com/llvm/llvm-project/pull/106012.diff
1 Files Affected:
- (modified) clang/lib/Basic/Targets/PPC.cpp (+5-3)
`
https://github.com/alexrp created
https://github.com/llvm/llvm-project/pull/106012
Fixes #105972.
From 5d52fe0d6d9bad77193a114eaef324d1799f2444 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?=
Date: Sun, 25 Aug 2024 22:47:37 +0200
Subject: [PATCH] [clang][Driver] Define
18 matches
Mail list logo
