https://github.com/hazohelet closed
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet updated
https://github.com/llvm/llvm-project/pull/65238:
>From 2bc13f3b013a4bda4364e9c29bc792ca6a0c7cf1 Mon Sep 17 00:00:00 2001
From: Takuya Shimizu
Date: Mon, 4 Sep 2023 10:46:17 +0900
Subject: [PATCH 1/3] [clang][Diagnostics] Fix wrong line number display
When t
https://github.com/hazohelet updated
https://github.com/llvm/llvm-project/pull/65238:
>From 2bc13f3b013a4bda4364e9c29bc792ca6a0c7cf1 Mon Sep 17 00:00:00 2001
From: Takuya Shimizu
Date: Mon, 4 Sep 2023 10:46:17 +0900
Subject: [PATCH 1/2] [clang][Diagnostics] Fix wrong line number display
When t
cor3ntin wrote:
could you upload a dummy change to trigger the build? Thanks!
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Okay, makes sense to me. Should probably also be backported to 17.
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hazohelet wrote:
> Ouch the inability to comment outside of modified code is going to be painful.
>
> The changed code being
>
> ```c++
> unsigned DisplayLineNo = Loc.getPresumedLoc().getLine();
> for (const auto &I : Ranges) {
> DisplayLineNo =
> std::min(DisplayLineNo, SM.g
cor3ntin wrote:
Ouch the inability to comment outside of modified code is going to be painful.
The changed code being
```cpp
unsigned DisplayLineNo = Loc.getPresumedLoc().getLine();
for (const auto &I : Ranges) {
DisplayLineNo =
std::min(DisplayLineNo, SM.getPresumedLineNumbe
hazohelet wrote:
When the `Loc` is higher than the lowest begin source location, `DisplayLineNo`
still points to the lowest begin location line because we have
```c++
DisplayLineNo =
std::min(DisplayLineNo, SM.getPresumedLineNumber(I.getBegin()));
```
in L1169, correct?
This does not b
tbaederr wrote:
In 8554a55d041f2c7de329adda538cadf7eeb6e8a8, this was added to fix a range with
a lower begin source location than `Loc` is, so I think this change would break
that?
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mail
cor3ntin wrote:
This looks good. My only question is, can `Loc` ever be invalid there, and what
happens if it is?
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/cor3ntin labeled
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet review_requested
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet review_requested
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet review_requested
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet created
https://github.com/llvm/llvm-project/pull/65238:
When the caret location is lower than the lowest source range, clang is
printing wrong line numbers. The first line number should consider caret
location line even when there are source ranges provided.
Curr
https://github.com/hazohelet review_requested
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet labeled
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hazohelet review_requested
https://github.com/llvm/llvm-project/pull/65238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
19 matches
Mail list logo
