https://github.com/jakeegan closed
https://github.com/llvm/llvm-project/pull/141439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen approved this pull request.
LGTM.
Thanks.
https://github.com/llvm/llvm-project/pull/141439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -933,11 +933,16 @@ ToolChain::getTargetSubDirPath(StringRef BaseDir) const {
if (auto Path = getPathForTriple(T))
return *Path;
- if (T.isOSAIX() && T.getEnvironment() == Triple::UnknownEnvironment) {
-// Strip unknown environment from the triple.
-const llvm
https://github.com/jakeegan updated
https://github.com/llvm/llvm-project/pull/141439
>From b044f81c6d1ed67ce7ee27bce7a62d36b3841bad Mon Sep 17 00:00:00 2001
From: Jake Egan
Date: Sun, 25 May 2025 19:40:59 -0400
Subject: [PATCH 1/4] Fix rt dir fallback
---
clang/lib/Driver/ToolChain.cpp
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/141439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/141439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -933,11 +933,16 @@ ToolChain::getTargetSubDirPath(StringRef BaseDir) const {
if (auto Path = getPathForTriple(T))
return *Path;
- if (T.isOSAIX() && T.getEnvironment() == Triple::UnknownEnvironment) {
-// Strip unknown environment from the triple.
-const llvm
https://github.com/jakeegan updated
https://github.com/llvm/llvm-project/pull/141439
>From b044f81c6d1ed67ce7ee27bce7a62d36b3841bad Mon Sep 17 00:00:00 2001
From: Jake Egan
Date: Sun, 25 May 2025 19:40:59 -0400
Subject: [PATCH 1/3] Fix rt dir fallback
---
clang/lib/Driver/ToolChain.cpp
@@ -933,11 +933,16 @@ ToolChain::getTargetSubDirPath(StringRef BaseDir) const {
if (auto Path = getPathForTriple(T))
return *Path;
- if (T.isOSAIX() && T.getEnvironment() == Triple::UnknownEnvironment) {
-// Strip unknown environment from the triple.
-const llvm
DanielCChen wrote:
Another related question but not necessarily in the scope of this PR:
It seems both `aix-ld.c` and `aix-rtlib.c` still have the "old" OS path in
test. They all pass though after we change the default to per target for
`libclang_rt*.a`. Is it expected? If so, should the change
@@ -933,11 +933,16 @@ ToolChain::getTargetSubDirPath(StringRef BaseDir) const {
if (auto Path = getPathForTriple(T))
return *Path;
- if (T.isOSAIX() && T.getEnvironment() == Triple::UnknownEnvironment) {
-// Strip unknown environment from the triple.
-const llvm
https://github.com/DanielCChen approved this pull request.
LGTM with a minor nit comment.
https://github.com/llvm/llvm-project/pull/141439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Jake Egan (jakeegan)
Changes
If the runtime path is not found (by getTargetSubDirPath()), since per target
runtime directory is enabled on AIX, we should fall back to the target
subdirectory rather than the OS subdirectory.
---
Fu
https://github.com/jakeegan ready_for_review
https://github.com/llvm/llvm-project/pull/141439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jakeegan updated
https://github.com/llvm/llvm-project/pull/141439
>From b044f81c6d1ed67ce7ee27bce7a62d36b3841bad Mon Sep 17 00:00:00 2001
From: Jake Egan
Date: Sun, 25 May 2025 19:40:59 -0400
Subject: [PATCH 1/2] Fix rt dir fallback
---
clang/lib/Driver/ToolChain.cpp
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions c,cpp --
clang/lib/Driver/ToolChain.cpp clang/test/Driver/ai
https://github.com/jakeegan created
https://github.com/llvm/llvm-project/pull/141439
If the runtime path is not found (by getTargetSubDirPath()), since per target
runtime directory is enabled on AIX, we should fall back to the target
subdirectory rather than the OS subdirectory.
>From b044f81
17 matches
Mail list logo
