https://github.com/AaronBallman commented:
In general, I think this is heading in the right direction. I did have a
suggestion that may be worth considering.
https://github.com/llvm/llvm-project/pull/93503
___
cfe-commits mailing list
cfe-commits@list
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/93503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -74,8 +74,8 @@ On Unix-like Systems
https://llvm.org/docs/CMake.html#frequently-used-cmake-variables";>frequently
used cmake variables
for more options.
AaronBallman wrote:
[Re: lines 72 to
76]
I think we should update this text at t
@@ -74,8 +74,8 @@ On Unix-like Systems
https://llvm.org/docs/CMake.html#frequently-used-cmake-variables";>frequently
used cmake variables
for more options.
-cmake -DLLVM_ENABLE_PROJECTS=clang -DCMAKE_BUILD_TYPE=Release -G
"Unix Makefiles" ../llvm
@@ -74,8 +74,8 @@ On Unix-like Systems
https://llvm.org/docs/CMake.html#frequently-used-cmake-variables";>frequently
used cmake variables
for more options.
-cmake -DLLVM_ENABLE_PROJECTS=clang -DCMAKE_BUILD_TYPE=Release -G
"Unix Makefiles" ../llvm
https://github.com/Endilll requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/93503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/93503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,15 +67,13 @@ On Unix-like Systems
Build LLVM and Clang:
cd llvm-project
-mkdir build (in-tree build is not supported)
-cd build
This builds both LLVM and Clang in release mode. Alternatively, if
you need a debug build, switch Release to Deb
https://github.com/SamuelMarks updated
https://github.com/llvm/llvm-project/pull/93503
>From bcdc355e9585e35f128a1b3ec71655d47bbf6986 Mon Sep 17 00:00:00 2001
From: Samuel Marks <807580+samuelma...@users.noreply.github.com>
Date: Tue, 28 May 2024 00:49:37 -0400
Subject: [PATCH 1/2] [clang/www/ge
@@ -67,15 +67,13 @@ On Unix-like Systems
Build LLVM and Clang:
cd llvm-project
-mkdir build (in-tree build is not supported)
-cd build
This builds both LLVM and Clang in release mode. Alternatively, if
you need a debug build, switch Release to Deb
@@ -67,15 +67,13 @@ On Unix-like Systems
Build LLVM and Clang:
cd llvm-project
-mkdir build (in-tree build is not supported)
-cd build
This builds both LLVM and Clang in release mode. Alternatively, if
you need a debug build, switch Release to Deb
https://github.com/Endilll requested changes to this pull request.
I'm fine with `cmake --build`, but I don't think that replacing `cd` with `-S`
and `-B` is an improvement.
https://github.com/llvm/llvm-project/pull/93503
___
cfe-commits mailing list
@@ -67,15 +67,13 @@ On Unix-like Systems
Build LLVM and Clang:
cd llvm-project
-mkdir build (in-tree build is not supported)
-cd build
This builds both LLVM and Clang in release mode. Alternatively, if
you need a debug build, switch Release to Deb
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/93503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,15 +67,13 @@ On Unix-like Systems
Build LLVM and Clang:
cd llvm-project
-mkdir build (in-tree build is not supported)
-cd build
This builds both LLVM and Clang in release mode. Alternatively, if
you need a debug build, switch Release to Deb
@@ -67,15 +67,13 @@ On Unix-like Systems
Build LLVM and Clang:
cd llvm-project
-mkdir build (in-tree build is not supported)
-cd build
This builds both LLVM and Clang in release mode. Alternatively, if
you need a debug build, switch Release to Deb
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Samuel Marks (SamuelMarks)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/93503.diff
1 Files Affected:
- (modified) clang/www/get_started.html (+8-8)
``diff
diff --git a/clang/www/get_started.html b/clang/w
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/SamuelMarks created
https://github.com/llvm/llvm-project/pull/93503
None
>From bcdc355e9585e35f128a1b3ec71655d47bbf6986 Mon Sep 17 00:00:00 2001
From: Samuel Marks <807580+samuelma...@users.noreply.github.com>
Date: Tue, 28 May 2024 00:49:37 -0400
Subject: [PATCH] [clang/www/
19 matches
Mail list logo
