https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/124448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/124448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kazutakahirata edited
https://github.com/llvm/llvm-project/pull/124448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kazutakahirata wrote:
> Can't this use DenseSet? It looks like the names here live for the lifetime
> of the set.
Good idea! Revised.
https://github.com/llvm/llvm-project/pull/124448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/kazutakahirata updated
https://github.com/llvm/llvm-project/pull/124448
>From 2273e9e518fa5625a40298a970dfd3ad1c3f27db Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 25 Jan 2025 16:07:33 -0800
Subject: [PATCH 1/3] [TableGen] Avoid repeated map lookups (NFC)
This patch
https://github.com/kazutakahirata updated
https://github.com/llvm/llvm-project/pull/124448
>From 2273e9e518fa5625a40298a970dfd3ad1c3f27db Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sat, 25 Jan 2025 16:07:33 -0800
Subject: [PATCH 1/2] [TableGen] Avoid repeated map lookups (NFC)
This patch
https://github.com/nikic commented:
Can't this use DenseSet? It looks like the names here live for the
lifetime of the set.
https://github.com/llvm/llvm-project/pull/124448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
This patch avoids repeated map lookups and constructions of temporary
std::string instances by switching to StringMap.
---
Full diff: https://github.com/llvm/llvm-project/pull/124448.diff
1 Files Aff
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/124448
This patch avoids repeated map lookups and constructions of temporary
std::string instances by switching to StringMap.
>From 2273e9e518fa5625a40298a970dfd3ad1c3f27db Mon Sep 17 00:00:00 2001
From: Kazu H