[clang] [TSAN] add support for riscv64 (PR #68735)

hiraditya wrote: Ah that's unfortunate.; sorry about that. In my local copy of git log (before merging) ``` commit 5b85613483861b3734edf9c94be390f2b3b0dd2a (HEAD -> riscv_tsan) Author: Alex Fan Date: Fri Oct 6 12:32:38 2023 -0700 ``` so i thought github would respect that. https://github.c

[clang] [TSAN] add support for riscv64 (PR #68735)

MaskRay wrote: > > The review context is on > > [reviews.llvm.org/D145214](https://reviews.llvm.org/D145214) . Moving it > > here just causes more confusion. > > @alexfanqi is the author of the patch and they can drive a reland. > > Can you elaborate what is confusing? The patch was already re

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/hiraditya closed https://github.com/llvm/llvm-project/pull/68735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/alexfanqi approved this pull request. https://github.com/llvm/llvm-project/pull/68735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/68735 >From 5b85613483861b3734edf9c94be390f2b3b0dd2a Mon Sep 17 00:00:00 2001 From: Alex Fan Date: Fri, 6 Oct 2023 12:32:38 -0700 Subject: [PATCH] add support for riscv64 Implements for sv39 and sv48 VMA layout. Us

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/68735 >From bcd63227792a992d6e5cd851d2fa2355d2f3c4f8 Mon Sep 17 00:00:00 2001 From: Alex Fan Date: Fri, 6 Oct 2023 12:32:38 -0700 Subject: [PATCH] [TSAN] add support for riscv64 Implements for sv39 and sv48 VMA layo

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/alexfanqi requested changes to this pull request. I missed a little piece for sv48 here ``` --- a/compiler-rt/lib/sanitizer_common/sanitizer_platform.h +++ b/compiler-rt/lib/sanitizer_common/sanitizer_platform.h @@ -303,7 +303,7 @@ #define SANITIZER_MMAP_RANGE_SIZE FIRST_3

[clang] [TSAN] add support for riscv64 (PR #68735)

alexfanqi wrote: Sorry. It took some time to reply. Since newer linux kernel supports sv57 and sv48, I tested this again with latest qemu and 6.6 kernel, by passing `-cpu rv64,sv48=on` to qemu. I missed a little piece here for sv48, Also to note, if we want to support sv57, we could directly

[clang] [TSAN] add support for riscv64 (PR #68735)

hiraditya wrote: > The review context is on https://reviews.llvm.org/D145214 . Moving it here > just causes more confusion. > > @alexfanqi is the author of the patch and they can drive a reland. Can you elaborate what is confusing? The patch was already reviewed and accepted. I'm waiting on t

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/MaskRay requested changes to this pull request. https://reviews.llvm.org/D145214#4653647 https://github.com/llvm/llvm-project/pull/68735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [TSAN] add support for riscv64 (PR #68735)

MaskRay wrote: The review context is on https://reviews.llvm.org/D145214 . Moving it here just causes more confusion. @alexfanqi is the author of the patch and they can drive a reland. https://github.com/llvm/llvm-project/pull/68735 ___ cfe-commits

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/zeroomega approved this pull request. LGTM. Please solve the code-formatting issues complaint by the bots. https://github.com/llvm/llvm-project/pull/68735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [TSAN] add support for riscv64 (PR #68735)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 08545e85167a105b8147d76a48a2fa1eac0f9e9a 512ba7677b5b6656fab25f5c2b31a1ef203d9756 --

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/hiraditya edited https://github.com/llvm/llvm-project/pull/68735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TSAN] add support for riscv64 (PR #68735)

llvmbot wrote: @llvm/pr-subscribers-clang Author: AdityaK (hiraditya) Changes Implements for sv39 and sv48 VMA layout. Userspace only has access to the bottom half of vma range. The top half is used by kernel. There is no dedicated vsyscall or heap segment. PIE program is allocated to st

[clang] [TSAN] add support for riscv64 (PR #68735)

https://github.com/hiraditya created https://github.com/llvm/llvm-project/pull/68735 Implements for sv39 and sv48 VMA layout. Userspace only has access to the bottom half of vma range. The top half is used by kernel. There is no dedicated vsyscall or heap segment. PIE program is allocated to s