[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-29 Thread Jameson Nash via cfe-commits
https://github.com/vtjnash updated https://github.com/llvm/llvm-project/pull/122330 >From 829e1c89ce869f782cb802a1d618003770c0d074 Mon Sep 17 00:00:00 2001 From: Jameson Nash Date: Thu, 9 Jan 2025 17:10:08 + Subject: [PATCH 1/2] [Sema] do not destruct fields of unions The C++ standard proh

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-24 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the fix! The changes look correct to me, but I added the CFG and Analysis maintainers to give a final sign-off. Can you also add something to `clang/docs/ReleaseNotes.rst` so users know about the fix? https://github.com/llvm/llvm-project

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-24 Thread Gabriel Baraldi via cfe-commits
gbaraldi wrote: Bump. For reference, this is holding julia to an older LLVM version than needed ;) https://github.com/llvm/llvm-project/pull/122330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-16 Thread Jameson Nash via cfe-commits
vtjnash wrote: This roughly corresponds to 921bd20dddf5080cdb36f39c0162eb63b2d5325e in Sema, I think (@zygoloid). Maybe @tkremenek or @yronglin has done something in this part of the code recently too as reviewers and to merge this? https://github.com/llvm/llvm-project/pull/122330

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Jameson Nash (vtjnash) Changes The C++ standard prohibits this implicit destructor call, leading to incorrect reports from clang-analyzer. This causes projects that use std::option (including llvm) to fail the cplusplus.NewDelete

[clang] [Sema] do not destruct fields of unions (PR #122330)

2025-01-09 Thread Jameson Nash via cfe-commits
https://github.com/vtjnash created https://github.com/llvm/llvm-project/pull/122330 The C++ standard prohibits this implicit destructor call, leading to incorrect reports from clang-analyzer. This causes projects that use std::option (including llvm) to fail the cplusplus.NewDelete test incorr