[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/116074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

https://github.com/bd1976bris edited https://github.com/llvm/llvm-project/pull/116074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

@@ -67,19 +67,24 @@ // CHECK-NO-EXE-NOT: "--unresolved-symbols // CHECK-NO-EXE-NOT: "-z" -// Test that an appropriate linker script is supplied by the driver. +// Test that an appropriate linker script is supplied by the driver, but can +// be overridden with -T. -

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

@@ -67,19 +67,24 @@ // CHECK-NO-EXE-NOT: "--unresolved-symbols // CHECK-NO-EXE-NOT: "-z" -// Test that an appropriate linker script is supplied by the driver. +// Test that an appropriate linker script is supplied by the driver, but can +// be overridden with -T. -

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

https://github.com/jmorse approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/116074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

https://github.com/bd1976bris approved this pull request. LGTM. I would have preferred a simpler way of checking that there are no other occurrences of -T/--script/--default-script but couldn't think of anything. I didn't notice that this was an upstream review initially. It would be worth wai

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

@@ -67,19 +67,24 @@ // CHECK-NO-EXE-NOT: "--unresolved-symbols // CHECK-NO-EXE-NOT: "-z" -// Test that an appropriate linker script is supplied by the driver. +// Test that an appropriate linker script is supplied by the driver, but can +// be overridden with -T. -

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Edd Dawson (playstation-edd) Changes If a linker script is explicitly supplied, there's no benefit to supplying a default script. SIE tracker: TOOLCHAIN-17524 --- Full diff: https://github.com/llvm/llvm-

[clang] [PS5][Driver] Allow `-T` to override `--default-script` (PR #116074)

https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/116074 If a linker script is explicitly supplied, there's no benefit to supplying a default script. SIE tracker: TOOLCHAIN-17524 >From a843f4fcd5bc0c43ad0177cb3e284efe65676138 Mon Sep 17 00:00:00 2001 From: E