https://github.com/playstation-edd closed
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,42 +1,64 @@
-// Check that PS4 clang doesn't report a warning message when locating
-// system header files (either by looking at the value of SCE_ORBIS_SDK_DIR
-// or relative to the location of the compiler driver), if "-nostdinc",
-// "--sysroot" or "-isysroot" option is
https://github.com/playstation-edd updated
https://github.com/llvm/llvm-project/pull/107410
>From a20158570f15b4200937650b90e07b99e230e3df Mon Sep 17 00:00:00 2001
From: Edd Dawson
Date: Wed, 4 Sep 2024 12:30:11 +0100
Subject: [PATCH 1/4] [PS4,PS5][Driver] Detangle --sysroot and -isysroot
The
https://github.com/playstation-edd updated
https://github.com/llvm/llvm-project/pull/107410
>From a20158570f15b4200937650b90e07b99e230e3df Mon Sep 17 00:00:00 2001
From: Edd Dawson
Date: Wed, 4 Sep 2024 12:30:11 +0100
Subject: [PATCH 1/3] [PS4,PS5][Driver] Detangle --sysroot and -isysroot
The
https://github.com/pogo59 approved this pull request.
LGTM, but pointed out the need for a test comment update (& replicate to the
PS5 equivalent test).
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.ll
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const
llvm::Triple &Triple,
const ArgList &Args, StringRef Platform,
const char *EnvVar)
: Generic_ELF(D, Triple, Args) {
- // D
https://github.com/pogo59 edited
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,42 +1,64 @@
-// Check that PS4 clang doesn't report a warning message when locating
-// system header files (either by looking at the value of SCE_ORBIS_SDK_DIR
-// or relative to the location of the compiler driver), if "-nostdinc",
-// "--sysroot" or "-isysroot" option is
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const
llvm::Triple &Triple,
const ArgList &Args, StringRef Platform,
const char *EnvVar)
: Generic_ELF(D, Triple, Args) {
- // D
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const
llvm::Triple &Triple,
const ArgList &Args, StringRef Platform,
const char *EnvVar)
: Generic_ELF(D, Triple, Args) {
- // D
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const
llvm::Triple &Triple,
const ArgList &Args, StringRef Platform,
const char *EnvVar)
: Generic_ELF(D, Triple, Args) {
- // D
playstation-edd wrote:
> According to [gcc
> docs](https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html) `--sysroot`
> applies to headers and libraries, and `-isysroot` overrides it for headers
> only. This is different from the "independence" described for World 2. That
> is, if we have
https://github.com/playstation-edd updated
https://github.com/llvm/llvm-project/pull/107410
>From a20158570f15b4200937650b90e07b99e230e3df Mon Sep 17 00:00:00 2001
From: Edd Dawson
Date: Wed, 4 Sep 2024 12:30:11 +0100
Subject: [PATCH 1/2] [PS4,PS5][Driver] Detangle --sysroot and -isysroot
The
pogo59 wrote:
FTR I have no good explanation for why the PS4 handling is in the state it's
in--thanks for sorting this!
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/pogo59 commented:
According to [gcc
docs](https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html) `--sysroot`
applies to headers and libraries, and `-isysroot` overrides it for headers
only. This is different from the "independence" described for World 2. That is,
if we
https://github.com/playstation-edd edited
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Edd Dawson (playstation-edd)
Changes
The following discrepancies concerning `-isysroot` and `--sysroot` motivated
this change:
- The SDK directory can be specified via `-isysroot`, but `--sysroot` has no
influence over this. Yet, we chec
https://github.com/playstation-edd created
https://github.com/llvm/llvm-project/pull/107410
The following discrepancies concerning `-isysroot` and `--sysroot` motivated
this change:
- The SDK directory can be specified via `-isysroot`, but `--sysroot` has no
influence over this. Yet, we check
18 matches
Mail list logo
