https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/88135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexey-bataev edited
https://github.com/llvm/llvm-project/pull/88135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11074,13 +11079,44 @@ OMPClause
*TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) {
//===--===//
// OpenACC transformation
//===--
https://github.com/alexey-bataev approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/88135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/88135
>From b0595276f2b8d74d036ff9bf94c5baea86a57f17 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 8 Apr 2024 14:23:17 -0700
Subject: [PATCH 1/3] g This is a combination of 3 commits.
[OpenACC] Implement Def
@@ -11074,13 +11079,44 @@ OMPClause
*TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) {
//===--===//
// OpenACC transformation
//===--
@@ -15,3 +15,22 @@
#include "clang/AST/ASTContext.h"
using namespace clang;
+
+OpenACCDefaultClause *OpenACCDefaultClause::Create(const ASTContext &C,
+ OpenACCDefaultClauseKind K,
+
@@ -11074,13 +11079,44 @@ OMPClause
*TreeTransform::TransformOMPXBareClause(OMPXBareClause *C) {
//===--===//
// OpenACC transformation
//===--
@@ -15,3 +15,22 @@
#include "clang/AST/ASTContext.h"
using namespace clang;
+
+OpenACCDefaultClause *OpenACCDefaultClause::Create(const ASTContext &C,
+ OpenACCDefaultClauseKind K,
+
@@ -12254,6 +12254,10 @@ def err_acc_construct_appertainment
"be used in a statement context">;
def err_acc_clause_appertainment
: Error<"OpenACC '%1' clause is not valid on '%0' directive">;
+def err_acc_duplicate_clause_diallowed
Sirraide wrot
@@ -63,8 +79,43 @@ SemaOpenACC::ActOnClause(ArrayRef
ExistingClauses,
return nullptr;
}
- // TODO OpenACC: Switch over the clauses we implement here and 'create'
- // them.
+ switch (Clause.getClauseKind()) {
+ case OpenACCClauseKind::Default: {
+// Restrictions
https://github.com/Sirraide commented:
Just happened to notice a few typos.
https://github.com/llvm/llvm-project/pull/88135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/88135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -419,6 +419,29 @@ enum class OpenACCDefaultClauseKind {
Invalid,
};
+template
+inline StreamTy &PrintOpenACCDefaultClauseKind(StreamTy &Out,
erichkeane wrote:
Note I noticed that we got this wrong in the other two places in this file (
where I copied t
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/88135
>From b0595276f2b8d74d036ff9bf94c5baea86a57f17 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 8 Apr 2024 14:23:17 -0700
Subject: [PATCH 1/2] g This is a combination of 3 commits.
[OpenACC] Implement Def
@@ -419,6 +419,29 @@ enum class OpenACCDefaultClauseKind {
Invalid,
};
+template
+inline StreamTy &PrintOpenACCDefaultClauseKind(StreamTy &Out,
alexey-bataev wrote:
```suggestion
inline StreamTy &printOpenACCDefaultClauseKind(StreamTy &Out,
```
https://g
@@ -66,6 +96,8 @@ template class OpenACCClauseVisitor {
switch (C->getClauseKind()) {
case OpenACCClauseKind::Default:
+ VisitOpenACCDefaultClause(*static_cast(C));
alexey-bataev wrote:
Can you make it just `cast(C)`?
https://github.com/llvm/ll
@@ -52,8 +57,18 @@ class SemaOpenACC : public SemaBase {
SourceLocation getEndLoc() const { return ClauseRange.getEnd(); }
+OpenACCDefaultClauseKind getDefaultClauseKind() const {
+ assert(ClauseKind == OpenACCClauseKind::Default);
alexey-bataev
@@ -51,6 +51,36 @@ class OpenACCClauseWithParams : public OpenACCClause {
SourceLocation getLParenLoc() const { return LParenLoc; }
};
+// A 'default' clause, has the optional 'none' or 'present' argument.
alexey-bataev wrote:
```suggestion
/// A 'default'
@@ -52,8 +57,18 @@ class SemaOpenACC : public SemaBase {
SourceLocation getEndLoc() const { return ClauseRange.getEnd(); }
+OpenACCDefaultClauseKind getDefaultClauseKind() const {
+ assert(ClauseKind == OpenACCClauseKind::Default);
+ return std::get(Details)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
As a followup to my previous commits, this is an implementation of a single
clause, in this case the 'default' clause. This implements all semantic
analysis for it on compute clauses, and continues to lea
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Erich Keane (erichkeane)
Changes
As a followup to my previous commits, this is an implementation of a single
clause, in this case the 'default' clause. This implements all semantic
analysis for it on compute clauses, and continue
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/88135
As a followup to my previous commits, this is an implementation of a single
clause, in this case the 'default' clause. This implements all semantic
analysis for it on compute clauses, and continues to leave
23 matches
Mail list logo
