https://github.com/NagyDonat closed
https://github.com/llvm/llvm-project/pull/128887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/128887
From 76f8417b8b46e7d036d98fa92890469654158e20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 26 Feb 2025 15:41:46 +0100
Subject: [PATCH 1/6] [NFC][analyzer] Simplify ownership of check
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/128887
From 76f8417b8b46e7d036d98fa92890469654158e20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 26 Feb 2025 15:41:46 +0100
Subject: [PATCH 1/5] [NFC][analyzer] Simplify ownership of check
@@ -201,24 +199,24 @@ class CheckerManager {
template
CHECKER *registerChecker(AT &&... Args) {
CheckerTag tag = getTag();
-CheckerRef &ref = CheckerTags[tag];
-assert(!ref && "Checker already registered, use getChecker!");
-
-CHECKER *checker = new CHECKER
@@ -41,8 +42,8 @@ CheckerManager::CheckerManager(AnalyzerOptions &AOptions,
}
CheckerManager::~CheckerManager() {
NagyDonat wrote:
Good suggestion, I didn't know that `= default` works with out-of-line
declarations.
https://github.com/llvm/llvm-project/pull
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/128887
From 76f8417b8b46e7d036d98fa92890469654158e20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 26 Feb 2025 15:41:46 +0100
Subject: [PATCH 1/4] [NFC][analyzer] Simplify ownership of check
@@ -185,13 +185,11 @@ class CheckerManager {
StringRef OptionName,
StringRef ExpectedValueDesc) const;
- using CheckerRef = CheckerBase *;
using CheckerTag = const void *;
- using CheckerDtor =
@@ -185,13 +185,11 @@ class CheckerManager {
StringRef OptionName,
StringRef ExpectedValueDesc) const;
- using CheckerRef = CheckerBase *;
using CheckerTag = const void *;
- using CheckerDtor =
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/128887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -185,13 +185,11 @@ class CheckerManager {
StringRef OptionName,
StringRef ExpectedValueDesc) const;
- using CheckerRef = CheckerBase *;
using CheckerTag = const void *;
- using CheckerDtor =
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Donát Nagy (NagyDonat)
Changes
Previously checker objects were created by raw `new` calls, which necessitated
managing and calling their destructors explicitly. This commit refactors this
convoluted logic by introducing
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/128887
Previously checker objects were created by raw `new` calls, which necessitated
managing and calling their destructors explicitly. This commit refactors this
convoluted logic by introducing `unique_ptr`s that
12 matches
Mail list logo
