jurahul wrote:
Its not clear to me if the failure is real or intermittent:
FAILURE
Failed to match LIBC_NAMESPACE::mkdirat(AT_FDCWD, TEST_DIR, S_IRWXU) against
Succeeds(0).
Expected return value to be equal to 0 but got -1.
Expected errno to be equal to "Success" but got "File exists".
https:
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`libc-x86_64-debian-fullbuild-dbg-asan` running on
`libc-x86_64-debian-fullbuild` while building `clang` at step 4 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/171/builds/10204
Here is
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/115573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1570,8 +1541,7 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
for (auto const &Group : GroupsInPedantic) {
const std::string &GroupName =
std::string(Group->getValueAsString("GroupName"));
- std::map::const_iterator RI =
-
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/115573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
@@ -970,10 +942,11 @@ struct DiagTextPrinter : DiagTextVisitor
{
void VisitPlural(PluralPiece *P) {
Result += "%plural{";
assert(P->Options.size() == P->OptionPrefixes.size());
-for (unsigned I = 0, End = P->Options.size(); I < End; ++I) {
- if (P->OptionPre
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
@@ -468,11 +442,9 @@ static StringRef getModifierName(ModifierType MT) {
return "objcclass";
case MT_ObjCInstance:
return "objcinstance";
- case MT_Unknown:
+ default:
jurahul wrote:
Done now.
https://github.com/llvm/llvm-project/pull/115573
_
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115573
>From 635b24a4e057d85de6c2935ed817b93b34916ed3 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 8 Nov 2024 16:04:53 -0800
Subject: [PATCH] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter
Use ra
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
@@ -970,10 +942,11 @@ struct DiagTextPrinter : DiagTextVisitor
{
void VisitPlural(PluralPiece *P) {
Result += "%plural{";
assert(P->Options.size() == P->OptionPrefixes.size());
-for (unsigned I = 0, End = P->Options.size(); I < End; ++I) {
- if (P->OptionPre
@@ -970,10 +942,11 @@ struct DiagTextPrinter : DiagTextVisitor
{
void VisitPlural(PluralPiece *P) {
Result += "%plural{";
assert(P->Options.size() == P->OptionPrefixes.size());
-for (unsigned I = 0, End = P->Options.size(); I < End; ++I) {
- if (P->OptionPre
@@ -185,10 +174,8 @@ static void groupDiagnostics(ArrayRef
Diags,
}
// Assign unique ID numbers to the groups.
- unsigned IDNo = 0;
- for (std::map::iterator
- I = DiagsInGroup.begin(), E = DiagsInGroup.end(); I != E; ++I, ++IDNo)
-I->second.IDNo = IDNo;
+ fo
@@ -468,11 +442,9 @@ static StringRef getModifierName(ModifierType MT) {
return "objcclass";
case MT_ObjCInstance:
return "objcinstance";
- case MT_Unknown:
+ default:
jurahul wrote:
Thanks. I'll revert this back.
https://github.com/llvm/llvm-proj
@@ -185,10 +174,8 @@ static void groupDiagnostics(ArrayRef
Diags,
}
// Assign unique ID numbers to the groups.
- unsigned IDNo = 0;
- for (std::map::iterator
- I = DiagsInGroup.begin(), E = DiagsInGroup.end(); I != E; ++I, ++IDNo)
-I->second.IDNo = IDNo;
+ fo
@@ -185,10 +174,8 @@ static void groupDiagnostics(ArrayRef
Diags,
}
// Assign unique ID numbers to the groups.
- unsigned IDNo = 0;
- for (std::map::iterator
- I = DiagsInGroup.begin(), E = DiagsInGroup.end(); I != E; ++I, ++IDNo)
-I->second.IDNo = IDNo;
+ fo
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Use range based for loops in Clang diagnostics emitter.
---
Full diff: https://github.com/llvm/llvm-project/pull/115573.diff
1 Files Affected:
- (modified) clang/utils/TableGen/ClangDiagnosticsEmitter.cpp (
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/115573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/115573
Use range based for loops in Clang diagnostics emitter.
>From af56060f8d27bb84ce642f6fd53de14ad8765bef Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 8 Nov 2024 16:04:53 -0800
Subject: [PATCH] [NFC][Clan
23 matches
Mail list logo
