https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/98451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bf4167fd1d06ff68da2cbea210a4ccfa045694d3
6c3f68439fd102070f183a77b7d58d49f399b43c --e
DanielKristofKiss wrote:
#83277 needs the `setBranchProtectionFnAttributes` function but that call is
from a static function so let's make it static.
https://github.com/llvm/llvm-project/pull/98451
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/5] [NFC][Clang] Move setfunctions of BranchProtectionInf
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/4] [NFC][Clang] Move setfunctions of BranchProtectionInf
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/3] [NFC][Clang] Move setfunctions of BranchProtectionInf
@@ -152,7 +152,7 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo {
diag::warn_target_unsupported_branch_protection_attribute)
<< Arch;
} else {
- BPI.setFnAttributes(*Fn);
+ setBranchProtectionFnAttributes(BPI, (*Fn
https://github.com/efriedma-quic approved this pull request.
LGTM with one minor comment
https://github.com/llvm/llvm-project/pull/98451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/98451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -133,7 +133,7 @@ class AArch64TargetCodeGenInfo : public TargetCodeGenInfo {
}
}
auto *Fn = cast(GV);
-BPI.setFnAttributes(*Fn);
+CGM.getTargetCodeGenInfo().setFnAttributes(BPI, *Fn);
DanielKristofKiss wrote:
oh right.
https://github.
@@ -413,6 +414,12 @@ class TargetCodeGenInfo {
return nullptr;
}
+ void setFnAttributes(const TargetInfo::BranchProtectionInfo &BPI,
DanielKristofKiss wrote:
agree, added.
https://github.com/llvm/llvm-project/pull/98451
___
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/2] [NFC][Clang] Move setfunctions of BranchProtectionInf
@@ -413,6 +414,12 @@ class TargetCodeGenInfo {
return nullptr;
}
+ void setFnAttributes(const TargetInfo::BranchProtectionInfo &BPI,
nikic wrote:
```suggestion
void setBranchProtectionFnAttributes(const TargetInfo::BranchProtectionInfo
&BPI,
```
Or
@@ -133,7 +133,7 @@ class AArch64TargetCodeGenInfo : public TargetCodeGenInfo {
}
}
auto *Fn = cast(GV);
-BPI.setFnAttributes(*Fn);
+CGM.getTargetCodeGenInfo().setFnAttributes(BPI, *Fn);
nikic wrote:
```suggestion
setFnAttributes(BPI,
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Daniel Kiss (DanielKristofKiss)
Changes
To reduce build times move them to TargetCodeGenInfo.
Refactor of #98329
---
Full diff: https://github.com/llvm/llvm-project/pull/98451.diff
5 Files Affected:
- (modified) clang/include/
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/98451
To reduce build times move them to TargetCodeGenInfo.
Refactor of #98329
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
16 matches
Mail list logo
