https://github.com/jsji closed https://github.com/llvm/llvm-project/pull/112816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/112816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/112816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jsji wrote:
@Sirraide @cor3ntin Updated, can you please have another look? Thanks.
https://github.com/llvm/llvm-project/pull/112816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 4d79a387c70f4460e7b82df171ba8db68c3a96aa Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/7] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 4d79a387c70f4460e7b82df171ba8db68c3a96aa Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/6] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 6b85331c4927c031fb8a937467cf62c5d0f80e64 Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/6] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 6b85331c4927c031fb8a937467cf62c5d0f80e64 Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/5] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
@@ -3148,11 +3148,13 @@ Parser::DeclGroupPtrTy
Parser::ParseCXXClassMemberDeclaration(
// we did nothing here, but this allows us to issue a more
// helpful diagnostic.
if (Tok.is(tok::kw_concept)) {
-Diag(Tok.getLocation(),
- DS.isFriendSpecified() || NextTo
@@ -3148,11 +3148,13 @@ Parser::DeclGroupPtrTy
Parser::ParseCXXClassMemberDeclaration(
// we did nothing here, but this allows us to issue a more
// helpful diagnostic.
if (Tok.is(tok::kw_concept)) {
-Diag(Tok.getLocation(),
- DS.isFriendSpecified() || NextTo
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 6b85331c4927c031fb8a937467cf62c5d0f80e64 Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/4] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 3eabcb305e4c666b897a084615e4d53fc8052020 Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/4] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 3eabcb305e4c666b897a084615e4d53fc8052020 Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/3] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
@@ -3150,8 +3150,8 @@ Parser::DeclGroupPtrTy
Parser::ParseCXXClassMemberDeclaration(
if (Tok.is(tok::kw_concept)) {
Diag(Tok.getLocation(),
DS.isFriendSpecified() || NextToken().is(tok::kw_friend)
- ? diag::err_friend_concept
- : diag::
+
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816
>From 3eabcb305e4c666b897a084615e4d53fc8052020 Mon Sep 17 00:00:00 2001
From: Jinsong Ji
Date: Fri, 18 Oct 2024 05:03:22 +0200
Subject: [PATCH 1/2] [NFC][Clang] Fix enumerated mismatch warning
MIME-Version: 1.0
Cont
https://github.com/Sirraide requested changes to this pull request.
This doesn’t seem right: that diagnostic is only used in the parser, which is
why it is in `DiagnosticParseKinds.td`. Instead, it’d be better to cast the two
diagnostic IDs that are causing the problem to `unsigned` where they’
https://github.com/jsji edited https://github.com/llvm/llvm-project/pull/112816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jinsong Ji (jsji)
Changes
This is one of the many PRs to fix errors with LLVM_ENABLE_WERROR=on. Built by
GCC 11.
Fix warning:
llvm-project/clang/lib/Parse/ParseDeclCXX.cpp:3153:14: error: enumerated
mismatch in conditional expression: ‘c
https://github.com/jsji created https://github.com/llvm/llvm-project/pull/112816
This is one of the many PRs to fix errors with LLVM_ENABLE_WERROR=on. Built by
GCC 11.
Fix warning:
llvm-project/clang/lib/Parse/ParseDeclCXX.cpp:3153:14: error: enumerated
mismatch in conditional expression: ‘cla
19 matches
Mail list logo
