https://github.com/antangelo closed
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2986,6 +2989,9 @@ void
MicrosoftCXXNameMangler::mangleCallingConvention(CallingConv CC) {
case CC_Swift: Out << 'S'; break;
antangelo wrote:
Done
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commit
https://github.com/antangelo updated
https://github.com/llvm/llvm-project/pull/96487
>From 1e95098e324860268d55e72a14090f9524c7dde1 Mon Sep 17 00:00:00 2001
From: Antonio Abbatangelo
Date: Mon, 24 Jun 2024 09:49:28 -0400
Subject: [PATCH 1/2] [MS ABI]: Support preserve_none in MS ABI
---
clang
@@ -2986,6 +2989,9 @@ void
MicrosoftCXXNameMangler::mangleCallingConvention(CallingConv CC) {
case CC_Swift: Out << 'S'; break;
rnk wrote:
The default case here should be a proper compiler error, not an unreachable,
since there's no good way to prevent arb
@@ -2986,6 +2989,9 @@ void
MicrosoftCXXNameMangler::mangleCallingConvention(CallingConv CC) {
case CC_Swift: Out << 'S'; break;
case CC_SwiftAsync: Out << 'W'; break;
case CC_PreserveMost: Out << 'U'; break;
+case CC_PreserveNone:
+ Out << 'V';
---
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk commented:
Thanks for looking at this, let's make this an error instead of a crash in the
future.
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
AaronBallman wrote:
Do you need me to land the changes on your behalf?
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> The `preserve_none` calling convention is new in clang 19 and hasn't been
> released yet; do fixes need a release note if they happen within the release
> cycle a feature is added?
Nope, no need for a release note in this case; I forgot that this was new for
clang 19 ra
antangelo wrote:
The `preserve_none` calling convention is new in clang 19 and hasn't been
released yet; do fixes need a release note if they happen within the release
cycle a feature is added?
https://github.com/llvm/llvm-project/pull/96487
___
cfe
https://github.com/AaronBallman approved this pull request.
Generally LGTM, though the changes should come with a release note in
`clang/docs/ReleaseNotes.rst` so users know about the fix.
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commit
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/96487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (antangelo)
Changes
Fixes ICE when compiling preserve_nonecc functions on Windows and adds support
for the calling convention on AArch64 for Windows targets.
---
Full diff: https://github.com/llvm/llvm-project/pull/96487.diff
4 Fil
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: None (antangelo)
Changes
Fixes ICE when compiling preserve_nonecc functions on Windows and adds support
for the calling convention on AArch64 for Windows targets.
---
Full diff: https://github.com/llvm/llvm-project/pull/96487.di
https://github.com/antangelo created
https://github.com/llvm/llvm-project/pull/96487
Fixes ICE when compiling preserve_nonecc functions on Windows and adds support
for the calling convention on AArch64 for Windows targets.
>From 1e95098e324860268d55e72a14090f9524c7dde1 Mon Sep 17 00:00:00 2001
16 matches
Mail list logo
