[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-15 Thread Hans Wennborg via cfe-commits
zmodem wrote: Thanks! I'll go ahead and push the button. Hope you feel better soon! https://github.com/llvm/llvm-project/pull/135611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Finding operator delete[] is still problematic, without it the extension is a security hazard, so reverting until the problem with operator delete[] is figured out. --- Patch is 86.63 KiB, trunc

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-15 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: @zmodem , @DKLoehr , please feel free to hit the submit button once the pre-commit is green. The revert was not clean, so I would prefer to wait for it. I'm feeling ill and may end up offline after some time. https://github.com/llvm/llvm-project/pull/135611 ___

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cppm,cpp -- clang/include/clang/AST/DeclCXX.h clang/includ

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-14 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem closed https://github.com/llvm/llvm-project/pull/135611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-14 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: The clang format concerns were in main branch before I came in, so I think they can be ignored. https://github.com/llvm/llvm-project/pull/135611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Mariya Podchishchaeva (Fznamznon) Changes Finding operator delete[] is still problematic, without it the extension is a security hazard, so reverting until the problem with operator delete[] is figured out. --- Patch is 86.63 Ki

[clang] [MS][clang] Revert vector deleting destructors support (PR #135611)

2025-04-14 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/135611 Finding operator delete[] is still problematic, without it the extension is a security hazard, so reverting until the problem with operator delete[] is figured out. >From 460d4807104c925232def63b516853f9ee22