[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-05 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `clang` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/7144 Here is the relevant piece

[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Mariya Podchishchaeva (Fznamznon) Changes Sometimes a non-array delete is treated as delete[] when input pointer is pointer to array. With vector deleting destructors support we now generate a virtual destructor call instead of si

[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-05 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/134088 Sometimes a non-array delete is treated as delete[] when input pointer is pointer to array. With vector deleting destructors support we now generate a virtual destructor call instead of simple loop over the e

[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Sometimes a non-array delete is treated as delete[] when input pointer is pointer to array. With vector deleting destructors support we now generate a virtual destructor call instead of simple loo

[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-04 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/134088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-03 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-03 Thread Mariya Podchishchaeva via cfe-commits
@@ -2033,6 +2033,9 @@ llvm::Value *MicrosoftCXXABI::EmitVirtualDestructorCall( ThisTy = D->getDestroyedType(); } + while (const ArrayType *ATy = ThisTy->getAsArrayTypeUnsafe()) Fznamznon wrote: Thanks for the catch! Yeah, I knew it drops qualifiers. I

[clang] [MS][clang] Fix crash on deletion of array of pointers (PR #134088)

2025-04-03 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/134088 >From 0d2b22f9af7868ec7b1f8b908fd61b791ea8434b Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Wed, 2 Apr 2025 06:35:12 -0700 Subject: [PATCH 1/2] [MS][clang] Fix crash on deletion of array of po